Add attribute for checking for deprecated Mac remote message interaction #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
Jul 19, 2024
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
* main: Add new deprecated Mac remote message attribute. (#903)
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
* main: Remove unused VPN session utilities (#898) Add new deprecated Mac remote message attribute. (#903) Resetting all state for the VPN will cancel the tunnel and stop the monitors (#900) Add support for skipping sending usage pixels for remote messages (#902) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#896) Removes the listen port from the wireguard client (#901) Be explicit when performing developer redirects (#884) C-S-S cross origin fixes Update C-S-S version (#892) Add a debug menu action to reset Remote Messages on macOS (#891) Add desktop specific RMF attributes (#883) Upload exception message to Sentry (#856) Add locale to broken site report (#889) Add new subfeature for duckplayer (#885) Swiftlint refactoring (#882) Remote Messaging Framework for macOS (#876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199333091098016/1207851439577905/f
iOS PR: duckduckgo/iOS#3107
macOS PR: duckduckgo/macos-browser#2995
What kind of version bump will this require?: Major
Optional:
Tech Design URL:
CC:
Description:
This PR adds a new attribute which can check whether a user interacted with a given remote message via the deprecated messaging system on macOS.
This new attribute is a clone of the
interactedWithMessageattribute, except we provide a different array. I considered simply appending the deprecated message IDs to the array we pass tointeractedWithMessage, but would prefer to keep the arrays distinct in case of reused IDs between the two.Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template