Fix VPN configuration removal to stop the tunnel #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
samsymons
reviewed
Jul 19, 2024
Comment on lines
+1159
to
+1160
| completionHandler?(nil) | ||
| await cancelTunnel(with: TunnelError.appRequestedCancellation) |
There was a problem hiding this comment.
Any reason the completion handler comes before the cancel operation?
There was a problem hiding this comment.
Yeah - I want to make sure the completion handler is always called to prevent things from getting into a weird state. It's very likely that cancelling the tunnel will try to deallocate the PacketTunnelProvider and I'm ware of what might happen if the completion wasn't called before.
samsymons
approved these changes
Jul 19, 2024
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 19, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f iOS PR: duckduckgo/iOS#3099 BSK PR: duckduckgo/BrowserServicesKit#900 ## Description: Fix the VPN configuration removal handling in the extension to stop the tunnel.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 19, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f macOS PR: duckduckgo/macos-browser#2991 BSK PR: duckduckgo/BrowserServicesKit#900 ## Description: Fix the VPN configuration removal handling in the extension to stop the tunnel.
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
* main: Remove unused VPN session utilities (#898) Add new deprecated Mac remote message attribute. (#903) Resetting all state for the VPN will cancel the tunnel and stop the monitors (#900) Add support for skipping sending usage pixels for remote messages (#902) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#896) Removes the listen port from the wireguard client (#901) Be explicit when performing developer redirects (#884) C-S-S cross origin fixes Update C-S-S version (#892) Add a debug menu action to reset Remote Messages on macOS (#891) Add desktop specific RMF attributes (#883) Upload exception message to Sentry (#856) Add locale to broken site report (#889) Add new subfeature for duckplayer (#885) Swiftlint refactoring (#882) Remote Messaging Framework for macOS (#876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f
iOS PR: duckduckgo/iOS#3099
macOS PR: duckduckgo/macos-browser#2991
What kind of version bump will this require?: Patch
Optional:
Tech Design URL:
CC:
Description:
Fix the VPN configuration removal handling in the extension to stop the tunnel.
Testing:
Test through the platform-specific PRs.
Definition of Done:
Internal references:
Software Engineering Expectations
Technical Design Template