Improve VPN logging logic #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
samsymons
reviewed
Jul 5, 2024
| os_log("🔵 Received error from adapter: %{public}@", log: .networkProtection, type: .error, message) | ||
| os_log("🔴 Received error from adapter: %{public}@", log: .networkProtection, type: .error, message) |
There was a problem hiding this comment.
I'd still love to do something more with this at some point, but definitely out of scope for this PR.
samsymons
approved these changes
Jul 5, 2024
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f macOS PR: duckduckgo/macos-browser#2939 BSK PR: duckduckgo/BrowserServicesKit#877 ## Description Improves the logging logic for the VPN.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f iOS PR: duckduckgo/iOS#3032 BSK PR: duckduckgo/BrowserServicesKit#877 ## Description Improves the logging logic for the VPN.
samsymons
added a commit
that referenced
this pull request
Jul 7, 2024
# By Diego Rey Mendez (2) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: Add connection tester failure pixels (#881) De-duplicate passwords on import (#869) Privacy Dashboard refactor (#879) Improve VPN logging logic (#877) Subscription refactoring #5 (#874) Fixes for Xcode16 (#864) Update the Privacy Pro status attribute to use an array. (#878) # Conflicts: # Sources/NetworkProtection/PacketTunnelProvider.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f
iOS PR: duckduckgo/iOS#3032
macOS PR: duckduckgo/macos-browser#2939
What kind of version bump will this require?: Major/Minor/Patch
Description
Improves the logging logic for the VPN.
Testing
Check the plartfom-specific PRs for instructions.
Internal references:
Software Engineering Expectations
Technical Design Template