Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Privacy Pro RMF changes #833

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented May 31, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/414235014887631/1207409447873013/f
iOS PR: duckduckgo/iOS#2911
macOS PR: duckduckgo/macos-browser#2831
What kind of version bump will this require?: Major

Description:

This PR adds a number of extra matching attributes for RMF:

  1. Privacy Pro days since subscribed
  2. Privacy Pro days until expiration

It also introduces a new placeholder image for Privacy Pro.

Steps to test this PR:

  1. See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from amddg44 May 31, 2024 23:34
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* main:
  Enable DBP Keychain Item Accessibility Migration (#827)
@samsymons samsymons merged commit 03e6b71 into main Jun 3, 2024
7 checks passed
@samsymons samsymons deleted the sam/additional-privacy-pro-rmf-changes branch June 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants