Pixels automatic naming prefixing fixed #810
Merged
+288
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicocappelli
commented
May 7, 2024
| @@ -0,0 +1,92 @@ | |||
| // | |||
| // DebugEvent.swift | |||
There was a problem hiding this comment.
Just moved in its own file
federicocappelli
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
May 8, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207238594885159/f CC: @ayoy @diegoreymendez @loremattei **Description**: - Adds duckduckgo/BrowserServicesKit#810 - Creates a new NonStandardPixel that uses NonStandardEvent - Names and frequencies fix from https://app.asana.com/0/30173902528854/1207202086855539/f and https://app.asana.com/0/30173902528854/1207236076008989/f `m_mac.` > `m_mac_`
samsymons
added a commit
that referenced
this pull request
May 10, 2024
* main: Enable gzip compression for Sync PATCH payloads (#803) autofill: send current language in runtime config (#808) Password manager survey update (#811) on iOS allow bookmarks in top hits (#812) Rename tests to avoid conflicts (#813) Bat.js fix (fix for installing content blocking rules multiple times) (#779) Pixels automatic naming prefixing fixed (#810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1207238594885159/f
iOS PR: -
macOS PR: duckduckgo/macos-browser#2751
CC: @ayoy @loremattei @diegoreymendez
What kind of version bump will this require?: Patch: 144.0.1
Description
This PR contains few improvements:
.an assertionError is fired (in Debug)NonStandardEventfor those legacy Pixels non following the new PixelKit naming conventions, these kinds of pixels will maintain the name without automatic alterations.Internal references:
Software Engineering Expectations
Technical Design Template