macOS: Tentative fix for VPN stop issues #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Apr 26, 2024
diegoreymendez
force-pushed
the
diego/investigate-tunnel-stop-issues
branch
from
a29350f to
158ad0e
Compare
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Apr 26, 2024
Task/Issue URL: https://app.asana.com/0/0/1207063924984126/f iOS PR: Not needed BSK PR: duckduckgo/BrowserServicesKit#794 ## Description: Tentative fix for an issue where the tunnel provider is taking a long time to stop.
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: For Stripe repurchase if on account with expired subscription then use accessToken (#800) VPN Metadata Improvements (#799) Add internal pages to suggestions (#796) Add pixels to track VPN wake and stop attempts (#797) macOS: Tentative fix for VPN stop issues (#794) Add parameter allowed encoding to error descriptions (#795) Allow Repurchase of a 3rd party subscription (#788) BSK: Bundle-Specfic Autofill Secure Vault Keychain Items (#785) PixelKit migration to BSK (#787) # Conflicts: # Sources/NetworkProtection/PacketTunnelProvider.swift
samsymons
added a commit
that referenced
this pull request
Apr 29, 2024
* main: Disable on-demand when the user initiates shutdown. (#790) For Stripe repurchase if on account with expired subscription then use accessToken (#800) VPN Metadata Improvements (#799) Add internal pages to suggestions (#796) Add pixels to track VPN wake and stop attempts (#797) macOS: Tentative fix for VPN stop issues (#794) Add parameter allowed encoding to error descriptions (#795) Allow Repurchase of a 3rd party subscription (#788) BSK: Bundle-Specfic Autofill Secure Vault Keychain Items (#785) PixelKit migration to BSK (#787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207063924984126/f
iOS PR: Not needed
macOS PR: duckduckgo/macos-browser#2689
What kind of version bump will this require?: Patch
Description:
Tentative fix for an issue where the tunnel provider is taking a long time to stop.
Testing
See macOS PR for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template