Allow Repurchase of a 3rd party subscription #788
Merged
+166
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasma13
reviewed
Apr 23, 2024
miasma13
reviewed
Apr 23, 2024
miasma13
reviewed
Apr 23, 2024
miasma13
approved these changes
Apr 23, 2024
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: For Stripe repurchase if on account with expired subscription then use accessToken (#800) VPN Metadata Improvements (#799) Add internal pages to suggestions (#796) Add pixels to track VPN wake and stop attempts (#797) macOS: Tentative fix for VPN stop issues (#794) Add parameter allowed encoding to error descriptions (#795) Allow Repurchase of a 3rd party subscription (#788) BSK: Bundle-Specfic Autofill Secure Vault Keychain Items (#785) PixelKit migration to BSK (#787) # Conflicts: # Sources/NetworkProtection/PacketTunnelProvider.swift
samsymons
added a commit
that referenced
this pull request
Apr 29, 2024
* main: Disable on-demand when the user initiates shutdown. (#790) For Stripe repurchase if on account with expired subscription then use accessToken (#800) VPN Metadata Improvements (#799) Add internal pages to suggestions (#796) Add pixels to track VPN wake and stop attempts (#797) macOS: Tentative fix for VPN stop issues (#794) Add parameter allowed encoding to error descriptions (#795) Allow Repurchase of a 3rd party subscription (#788) BSK: Bundle-Specfic Autofill Secure Vault Keychain Items (#785) PixelKit migration to BSK (#787)
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
May 3, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1206382263248900/f **Description**: Support expired subscription state and subscription repurchase. Repurchase is done on a platform that is matching the app distribution (independent to where it was originally bought). Changes for supporting repurchase flows are/were implemented in BSK in the following PRs: - App Store repurchase: duckduckgo/BrowserServicesKit#788 - Stripe repurchase: duckduckgo/BrowserServicesKit#800 **Steps to test this PR**: 1. Activate expired subscription via email 2. Repurchase expired App Store subscription on Stripe 3. Repurchase expired Stripe subscription on App Store 4. Repurchase expired Stripe subscription on Stripe --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Daniel Bernal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1204099484721401/1207112724044306/f
iOS PR: https://github.com/duckduckgo/iOS/pull/2764/files
macOS PR: duckduckgo/macos-browser#2688
What kind of version bump will this require?: Major
Description:
Steps to test this PR: