Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back CPM post-rollout cleanup #730

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Mar 15, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/414235014887631/1206850469068241/f
iOS PR: duckduckgo/iOS#2599
macOS PR: duckduckgo/macos-browser#2430
What kind of version bump will this require?: Minor

Optional:

Tech Design URL:
CC:

Description:

Rolls back #697

Steps to test this PR:

  1. App builds successfully

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 self-assigned this Mar 15, 2024
@dus7 dus7 marked this pull request as ready for review March 15, 2024 11:53
@dus7 dus7 merged commit bcafd20 into main Mar 15, 2024
12 checks passed
@dus7 dus7 deleted the mariusz/rollback-cpm-default branch March 15, 2024 12:25
afterxleep pushed a commit that referenced this pull request Mar 15, 2024
samsymons added a commit that referenced this pull request Mar 18, 2024
* main:
  Improves VPN pixel info and adds tests (#732)
  Reset Cache on Subscription Purchase & Restore (#719)
  Revert "Remove Autoconsent subfeature (#697)" (#730)
  Stub objects for Bookmarks sync (#713)
samsymons added a commit that referenced this pull request Mar 18, 2024
* main:
  Update wireguard-apple to 1.1.3. (#729)
  Improves VPN pixel info and adds tests (#732)
  Reset Cache on Subscription Purchase & Restore (#719)
  Revert "Remove Autoconsent subfeature (#697)" (#730)
  Stub objects for Bookmarks sync (#713)
  make history entry weak to avoid retain cycle (#727)
  NetP x Subscription Clean-up (#709)
  Moves AppLaunching out of BSK as it's macOS only (#721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants