Handle subscription-related iOS use cases #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/Subscription/AccountManager.swift
# Conflicts: # Sources/NetworkProtection/KeyManagement/NetworkProtectionTokenStore.swift
quanganhdo
commented
Mar 15, 2024
Sources/NetworkProtection/Networking/NetworkProtectionClient.swift
Outdated
Show resolved
Hide resolved
samsymons
approved these changes
Mar 18, 2024
samsymons
added a commit
that referenced
this pull request
Mar 20, 2024
samsymons
added a commit
that referenced
this pull request
Mar 21, 2024
* main: Entitlements cache fixes (#736) Surface the last-used password first in autofill prompt when filling passwords (#731) RMF update adding build number to app version check (#708) VPN UI improvements (#722) Adds Privacy Pro Feature Flags (#717) macOS: Display error messaging for cancelled subscriptions (#714) Handle subscription-related iOS use cases (#728) Remove hardcoded NetP endpoint (#734) Use History in Suggestions on iOS (#705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414235014887631/1206844393131400/f
iOS PR: duckduckgo/iOS#2597
macOS PR: duckduckgo/macos-browser#2427
What kind of version bump will this require?: Minor
Optional:
Tech Design URL:
CC:
Description:
This PR updates the subscription endpoint and add a UserDefaults field for the thank you messaging.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template