Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Link Tracking Protection to preserve headers #600

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Update Link Tracking Protection to preserve headers #600

merged 6 commits into from
Dec 22, 2023

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Dec 13, 2023 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1163321984198618/1202368115363949/f
iOS PR: duckduckgo/iOS#2268
macOS PR: duckduckgo/macos-browser#1965
What kind of version bump will this require?: Major

Optional:

Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. See platform PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Dec 13, 2023
@SlayterDev SlayterDev marked this pull request as ready for review December 13, 2023 19:14
@SlayterDev SlayterDev requested a review from bwaresiak December 20, 2023 14:38
bwaresiak
bwaresiak approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SlayterDev SlayterDev merged commit 2c1c2bb into main Dec 22, 2023
5 checks passed
@SlayterDev SlayterDev deleted the brad/url-request-rewrite branch December 22, 2023 14:28
samsymons added a commit that referenced this pull request Dec 24, 2023
@samsymons
Merge branch 'main' into sam/add-netp-subscription-auth-support
8dd2ee0 
* main:
  Update latency & tunnel failure monitors implementation (#613)
  Prevents VPNSettings from reporting fake changes (#614)
  Update Link Tracking Protection to preserve headers (#600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees

@SlayterDev SlayterDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayterDev @bwaresiak