Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linter issues #592

Merged
merged 20 commits into from
Dec 18, 2023
Merged

fix linter issues #592

merged 20 commits into from
Dec 18, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Dec 6, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1206092817008017/f
iOS PR: duckduckgo/iOS#2227
macOS PR: duckduckgo/macos-browser#1318
What kind of version bump will this require?: -

Description:

  • Fix linter issues after adding SwiftLint as build plugin

Steps to test this PR:

  1. Validate no linter issues on CI
  2. Validate no linter issues in Xcode

@mallexxx mallexxx requested a review from samsymons December 6, 2023 13:30
@mallexxx mallexxx mentioned this pull request Dec 6, 2023
2 tasks
@mallexxx mallexxx changed the base branch from alex/swiftlint-plugin to main December 6, 2023 14:04
@mallexxx mallexxx force-pushed the alex/fix-linter-issues branch from 7b12786 to 26a0aea Compare December 6, 2023 18:13
@mallexxx mallexxx changed the base branch from main to alex/swiftlint-plugin December 7, 2023 12:05
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no SwiftLint issues locally or on CI and the changes look good.

@mallexxx mallexxx merged commit 98055df into alex/swiftlint-plugin Dec 18, 2023
5 checks passed
@mallexxx mallexxx deleted the alex/fix-linter-issues branch December 18, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants