Fix geoswitching + environment selection bugs #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
changed the title
This was referenced Nov 24, 2023
quanganhdo
approved these changes
Nov 27, 2023
federicocappelli
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 27, 2023
Task/Issue URL: https://app.asana.com/0/0/1206025077480506/f BSK: duckduckgo/BrowserServicesKit#576 Description: There was a bug with location switching where the user’s choice wasn’t always being respected. I noticed that there was a place where we weren’t passing it. I also noticed that we’re sometimes not using the selected environment because of the default function arguments, so I also updated them as it’s a somewhat related issue. Steps to test this PR: - Just make sure NetP / env selection still works --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1206025077480506/f
iOS PR: duckduckgo/iOS#2194
macOS PR: duckduckgo/macos-browser#1887
What kind of version bump will this require?: Minor
Description:
There was a bug with location switching where the user’s choice wasn’t always being respected. I noticed that there was a place where we weren’t passing it. I also noticed that we’re sometimes not using the selected environment because of the default function arguments, so I also updated them as it’s a somewhat related issue.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template