Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User segmentation migrated from iOS to BSK #1181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tomasstrba
Copy link
Contributor

@tomasstrba tomasstrba commented Jan 22, 2025

Task/Issue URL: https://app.asana.com/0/1148564399326804/1208850443048792/f
iOS PR: duckduckgo/iOS#3857
macOS PR: duckduckgo/macos-browser#3774
What kind of version bump will this require?: Minor

Optional:

Tech Design URL: https://app.asana.com/0/1148564399326804/1209193276521181/f

Description:

Steps to test this PR:

  1. Make sure tests pass. Other tests are listed in User segmentation migrated from iOS to BSK iOS#3857

Internal references:

Software Engineering Expectations
Technical Design Template

@tomasstrba tomasstrba changed the title User segmentation moved from iOS to BSK User segmentation moved migrated from iOS to BSK Jan 23, 2025
@tomasstrba tomasstrba changed the title User segmentation moved migrated from iOS to BSK User segmentation migrated from iOS to BSK Jan 23, 2025
@tomasstrba tomasstrba requested a review from brindy January 23, 2025 18:18
@tomasstrba tomasstrba marked this pull request as ready for review January 23, 2025 18:21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change in the Atb.swift


public final class UsageSegmentation: UsageSegmenting {

public var pixelEvents: EventMapping<UsageSegmentationPixel>?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PixelFiring replaced with EventMapping to fire pixels in clients as discussed in the tech design

Copy link
Contributor Author

@tomasstrba tomasstrba Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change in UsageSegmentationCalculator.swift

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change in UsageSegmentationStorage.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant