-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User segmentation migrated from iOS to BSK #1181
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change in the Atb.swift
|
||
public final class UsageSegmentation: UsageSegmenting { | ||
|
||
public var pixelEvents: EventMapping<UsageSegmentationPixel>? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PixelFiring replaced with EventMapping to fire pixels in clients as discussed in the tech design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change in UsageSegmentationCalculator.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change in UsageSegmentationStorage.swift
Task/Issue URL: https://app.asana.com/0/1148564399326804/1208850443048792/f
iOS PR: duckduckgo/iOS#3857
macOS PR: duckduckgo/macos-browser#3774
What kind of version bump will this require?: Minor
Optional:
Tech Design URL: https://app.asana.com/0/1148564399326804/1209193276521181/f
Description:
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template