Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not base cache expiry on subscription expiry date #1150

Merged

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Jan 8, 2025

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1201037661562251/1209111606760738/f
iOS PR: /will follow in internal build - not impacted/
macOS PR: duckduckgo/macos-browser#3714
What kind of version bump will this require?: Hotfix

Optional:

CC: @federicocappelli

Description:
In specific conditions we may cause an endless loop of remote API calls to fetch the subscription.

Steps to test this PR:
(macOS only)

  1. Have an expired subscription in the app
  2. Ensure that isLaunchedROW or isLaunchedROWOverride feature flag is enabled in privacy config.
  3. Open Settings tab
  4. From sidebar open "Privacy Pro"
  5. Check network calls: only a single remote call should be made to GET subscription from subscriptions BE endpoint

OS Testing:

  • macOS

Internal references:

Software Engineering Expectations
Technical Design Template

@miasma13 miasma13 requested a review from samsymons January 8, 2025 21:26
@miasma13 miasma13 merged commit 2eddeb9 into hotfix/223.0.0-1 Jan 9, 2025
9 checks passed
@miasma13 miasma13 deleted the michal/fix-expired-subscription-refresh-loop branch January 9, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants