Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malware protection pixels #1134

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Malware protection pixels #1134

merged 4 commits into from
Dec 20, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Dec 18, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208997802565798/f
iOS PR: duckduckgo/iOS#3735
macOS PR: duckduckgo/macos-browser#3672
What kind of version bump will this require?: Major

Description:

  • Update pixel definition according to spec

Steps to test this PR:

  1. Open malware/phishing test pages, validate errorPageShown pixel is fired with correct category + clientSideHit parameter
  2. Choose Accept risk and navigate, validate visitSite is fired
  3. load malware iFrame, validate iframeLoaded is fired
  4. toggle the Malicious Site Protection Setting, validate settingToggled is fired for on/off value

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

This was referenced Dec 18, 2024
Merged
Merged
not-a-rootkit
not-a-rootkit approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@not-a-rootkit not-a-rootkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to match the spec, thanks for doing this Alex!

@mallexxx mallexxx merged commit e8f94cf into main Dec 20, 2024
7 checks passed
@mallexxx mallexxx deleted the alex/malware-protection-pixels branch December 20, 2024 06:35
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Dec 20, 2024
@mallexxx
Update malware protection pixels (#3672)
2d30bf3 
Task/Issue URL: https://app.asana.com/0/1202406491309510/1208997802565798/f
BSK PR: duckduckgo/BrowserServicesKit#1134
iOS PR: duckduckgo/iOS#3735
mallexxx added a commit to duckduckgo/iOS that referenced this pull request Dec 24, 2024
@mallexxx
BSK -> alex/malware-protection-pixels (#3735)
1da9230 
Task/Issue URL: https://app.asana.com/0/1202406491309510/1208997802565798/f
BSK PR: duckduckgo/BrowserServicesKit#1134
macOS PR: duckduckgo/macos-browser#3672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-a-rootkit not-a-rootkit not-a-rootkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @not-a-rootkit