Update local network routing #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ struct VPNRoutingTableResolver { | |||
| var routes = VPNRoutingRange.publicNetworkRange + dnsRoutes() | |||
|
|
|||
| if !excludeLocalNetworks { | |||
| routes += VPNRoutingRange.localNetworkRange | |||
| routes += VPNRoutingRange.localNetworkRangeWithDNS | |||
There was a problem hiding this comment.
Feel free to ignore cos this is nitpicky. actually think the names should be the the opposite, because technically speaking 10/8 is part of the local network range. ie:
localNetworkRange > localNetworkRangeExceptDNS
localNetworkRangeWithDNS > localNetworkRange
There was a problem hiding this comment.
This is a great point, completely agreed.
diegoreymendez
approved these changes
Dec 6, 2024
samsymons
deleted the
sam/include-dns-range-when-including-local-networks
branch
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
* main: (24 commits) change api (#1133) Ensure authToken is present before calling refreshAuthTokenIfNeeded Add 'locale' to report broken site params Add 'locale' to report broken site params Ensure authToken is present before calling refreshAuthTokenIfNeeded Privacy Pro Free Trials - Models and API (#1120) remove MaliciousSiteProtectionSubfeature (#1131) Malware protection 6: Malware integration (#1099) Add underlying error to PrivacyStatsError (#1130) Initial changes for compilation time tracking. (#1111) iOS System level credential provider (#1127) Increase ratio of complete form saves (#1124) Add PrivacyStatsError.failedToClearPrivacyStats (#1128) Update autofill to 16.0.0 (#1122) Update local network routing (#1117) Update RMF version matching to ignore build number (#1118) Fix threading issue between using a Semaphore and async/await (#1115) add experiment test fake feature (#1119) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `a603ff9` to `6133e7d` (#1109) experiment default metrics pixels (#1107) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199230911884351/1208918011157080/f
iOS PR: TODO
macOS PR: TODO
What kind of version bump will this require?: Patch
Optional:
Tech Design URL:
CC:
Description:
This PR updates local network routing. When including local networks,
10.0.0.0/8will also go through the tunnel.Steps to test this PR:
dig @10.11.12.1 duckduckgo.com +shortand verify that an IP comes backdig @10.11.12.2 duckduckgo.com +shortand verify that an IP comes backOS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template