experiment framework #1100
Merged
experiment framework #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
commented
Nov 28, 2024
jaceklyp
requested changes
Nov 28, 2024
Sources/BrowserServicesKit/FeatureFlagger/ExperimentCohortsManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/FeatureFlagger/ExperimentCohortsManager.swift
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,8 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| public protocol FlagCohort: RawRepresentable, CaseIterable where RawValue == CohortID {} | |||
There was a problem hiding this comment.
could it be possibly be named just "Cohort"?
There was a problem hiding this comment.
I was just concerned it might get confused with PrivacyConfigurationData.Cohort
Sources/BrowserServicesKit/FeatureFlagger/ExperimentCohortsManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/FeatureFlagger/ExperimentCohortsManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/PrivacyConfig/PrivacyConfiguration.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208687542689225/f
iOS PR: duckduckgo/iOS#3636
macOS PR: duckduckgo/macos-browser#3606
What kind of version bump will this require?: Major
Optional:
Tech Design URL: https://app.asana.com/0/1204186595873227/1208823859841917/f
CC:
Description: Implements the new A/B/N experiment framework
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template