Malware protection 6: Malware integration #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1202406491309510/1208033567421351/f Tech design: https://app.asana.com/0/481882893211075/1208736595187321/f iOS PR: macOS PR: duckduckgo/macos-browser#3598 What kind of version bump will this require?: Major **Description**: - Refactored Malicious Site `DataManager` to `actor` for thread safe data storage with generic accessors and related file storage/update manager - Added dedicated FilterDictionary/HashPrefixSet structures storing revision inside the structs and for faster data access <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. Activate Feature Flag override for malicious site protections in Debug -> Feature Flag overrides 2. Visit https://privacy-test-pages.site/security/badware/phishing.html, validate phishing detection works without changes 3. Validate tests pass and the update manager works as before 1. <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Base automatically changed from
alex/malware-protection-5
to
alex/malware-protection-1
December 3, 2024 11:37
SabrinaTardio
approved these changes
Dec 5, 2024
14 tasks
**Required**: Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f iOS PR: NA macOS PR: NA What kind of version bump will this require?: Major/Minor/Patch **Description**: Updates Privacy Dashboard and C-S-S versions to latest
mallexxx
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 10, 2024
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Dec 10, 2024
Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f BSK PR: duckduckgo/BrowserServicesKit#1099 - add .malware threat and special page types
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
* main: (24 commits) change api (#1133) Ensure authToken is present before calling refreshAuthTokenIfNeeded Add 'locale' to report broken site params Add 'locale' to report broken site params Ensure authToken is present before calling refreshAuthTokenIfNeeded Privacy Pro Free Trials - Models and API (#1120) remove MaliciousSiteProtectionSubfeature (#1131) Malware protection 6: Malware integration (#1099) Add underlying error to PrivacyStatsError (#1130) Initial changes for compilation time tracking. (#1111) iOS System level credential provider (#1127) Increase ratio of complete form saves (#1124) Add PrivacyStatsError.failedToClearPrivacyStats (#1128) Update autofill to 16.0.0 (#1122) Update local network routing (#1117) Update RMF version matching to ignore build number (#1118) Fix threading issue between using a Semaphore and async/await (#1115) add experiment test fake feature (#1119) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `a603ff9` to `6133e7d` (#1109) experiment default metrics pixels (#1107) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f
iOS PR: duckduckgo/iOS#3690
macOS PR: duckduckgo/macos-browser#3604
What kind of version bump will this require?: Major
Description:
.malwarethreat and special page typesSteps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template