Skip to content

Commit

Permalink
Add 'locale' to report broken site params (#1132)
Browse files Browse the repository at this point in the history
**Required**:

Task/Issue URL:
https://app.asana.com/0/414709148257752/1208827075841585/f
iOS PR: duckduckgo/iOS#3717
macOS PR: duckduckgo/macos-browser#3661
What kind of version bump will this require?: Major

**Description**:
Add the "locale" param ID to the list of properties submitted in the
Privacy Dashboard site breakage form.

**Steps to test this PR**:
See respective platform PRs.


**OS Testing**:

* [ ] iOS 14
* [ ] iOS 15
* [ ] iOS 16
* [ ] macOS 10.15
* [ ] macOS 11
* [ ] macOS 12

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)

---------

Co-authored-by: Alexey Martemyanov <[email protected]>
  • Loading branch information
miasma13 and mallexxx authored Dec 12, 2024
1 parent fb809ed commit 41d614a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,6 @@ public enum DuckPlayerSubfeature: String, PrivacySubfeature {
case enableDuckPlayer // iOS DuckPlayer rollout feature
}

public enum MaliciousSiteProtectionSubfeature: String, PrivacySubfeature {
public var parent: PrivacyFeature { .maliciousSiteProtection }
case allowErrorPage
}

public enum SyncPromotionSubfeature: String, PrivacySubfeature {
public var parent: PrivacyFeature { .syncPromotion }
case bookmarks
Expand Down
1 change: 1 addition & 0 deletions Sources/PrivacyDashboard/PrivacyDashboardUserScript.swift
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ final class PrivacyDashboardUserScript: NSObject, StaticUserScript {
{"id": "jsPerformance"},
{"id": "openerContext"},
{"id": "userRefreshCount"},
{"id": "locale"},
]
}
window.onGetToggleReportOptionsResponse(json);
Expand Down

0 comments on commit 41d614a

Please sign in to comment.