Skip to content

Commit

Permalink
More linting fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jdjackson committed Dec 9, 2024
1 parent 4cb1360 commit 1d3a373
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions Sources/Crashes/CrashCollection.swift
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ public final class CrashCollection {
}
}



// TODO: This should really be its own file, but adding a new file to BSK and propagating it to iOS and macOS projects is hard. This can be done as a separate PR once the main changes land across all 3 repos

Check failure on line 209 in Sources/Crashes/CrashCollection.swift

View workflow job for this annotation

GitHub Actions / Run SwiftLint

TODOs should be resolved (This should really be its own ...) (todo)
// import Foundation
// import Persistence
Expand Down
10 changes: 5 additions & 5 deletions Tests/CrashesTests/CrashCollectionTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import TestUtils
class CrashCollectionTests: XCTestCase {

func testFirstCrashFlagSent() {
let crashCollection = CrashCollection(crashReportSender: CrashReportSender(platform: .iOS), crashCollectionStorage: MockKeyValueStore())
let crashCollection = CrashCollection(crashReportSender: CrashReportSender(platform: .iOS), crashCollectionStorage: MockKeyValueStore())
// 2 pixels with first = true attached
XCTAssertTrue(crashCollection.isFirstCrash)
crashCollection.start { pixelParameters, _, _ in
Expand All @@ -42,7 +42,7 @@ class CrashCollectionTests: XCTestCase {
}

func testSubsequentPixelsDontSendFirstFlag() {
let crashCollection = CrashCollection(crashReportSender: CrashReportSender(platform: .iOS), crashCollectionStorage: MockKeyValueStore())
let crashCollection = CrashCollection(crashReportSender: CrashReportSender(platform: .iOS), crashCollectionStorage: MockKeyValueStore())
// 2 pixels with no first parameter
crashCollection.isFirstCrash = false
crashCollection.start { pixelParameters, _, _ in
Expand All @@ -64,7 +64,7 @@ class CrashCollectionTests: XCTestCase {
let store = MockKeyValueStore()
let crashReportSender = MockCrashReportSender(platform: .iOS)
crashReportSender.responseCRCID = responseCRCIDValue
let crashCollection = CrashCollection(crashReportSender: crashReportSender , crashCollectionStorage: store)
let crashCollection = CrashCollection(crashReportSender: crashReportSender, crashCollectionStorage: store)
let expectation = self.expectation(description: "Crash collection response")

// Set up closures on our CrashCollection object
Expand Down Expand Up @@ -94,7 +94,7 @@ class CrashCollectionTests: XCTestCase {
{
let store = MockKeyValueStore()
let crashReportSender = MockCrashReportSender(platform: .iOS)
let crashCollection = CrashCollection(crashReportSender: crashReportSender , crashCollectionStorage: store)
let crashCollection = CrashCollection(crashReportSender: crashReportSender, crashCollectionStorage: store)
let expectation = self.expectation(description: "Crash collection response")

// Set up closures on our CrashCollection object
Expand Down Expand Up @@ -124,7 +124,7 @@ class CrashCollectionTests: XCTestCase {
func testCRCIDIsRetainedWhenServerErrorIsReceived() {
let store = MockKeyValueStore()
let crashReportSender = MockCrashReportSender(platform: .iOS)
let crashCollection = CrashCollection(crashReportSender: crashReportSender , crashCollectionStorage: store)
let crashCollection = CrashCollection(crashReportSender: crashReportSender, crashCollectionStorage: store)
let expectation = self.expectation(description: "Crash collection response")

// Set up closures on our CrashCollection object
Expand Down

0 comments on commit 1d3a373

Please sign in to comment.