[Draft] SwiftLint updates #3187
samsymonspr.yml
on: pull_request
Run SwiftLint
34s
Run unit tests (macOS)
4m 8s
Run unit tests (iOS)
2m 51s
Annotations
8 errors, 12 warnings, and 6 notices
|
Run SwiftLint:
Tests/BrowserServicesKitTests/SecureVault/AutofillKeyStoreProviderTests.swift#L39
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run SwiftLint:
Tests/BrowserServicesKitTests/SecureVault/AutofillKeyStoreProviderTests.swift#L73
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run SwiftLint:
Tests/BrowserServicesKitTests/SecureVault/AutofillKeyStoreProviderTests.swift#L110
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run SwiftLint:
Sources/Common/TLD/TLD.swift#L35
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run SwiftLint:
Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift#L257
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run SwiftLint:
Sources/PixelKit/Extensions/String+StaticString.swift#L24
Prefer failable `String(bytes:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
|
|
Run unit tests (macOS):
NavigationTests/NavigationResponderMock.swift#L225
event received after test completed: navResponseBecameDownload(0, http://localhost:8084/2, line: 342)
|
|
Run unit tests (macOS)
Process completed with exit code 1.
|
|
Run SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run unit tests (iOS):
DerivedData/Build/Products/Debug-iphonesimulator/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L63
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/NetworkProtection/Networking/NetworkProtectionClient.swift#L186
capture of 'formatter' with non-sendable type 'ISO8601DateFormatter' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterDidStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureBeforeWillStartNavigation
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequest
|
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestWithData
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build-log.txt
|
36.3 KB |
|
|
ios-build-log.txt
|
139 KB |
|