Malware protection 3: Refactor Data storing #3000
pr.yml
on: pull_request
Run SwiftLint
39s
Run unit tests (macOS)
3m 0s
Run unit tests (iOS)
4m 28s
Annotations
12 errors, 17 warnings, and 6 notices
Run SwiftLint:
Sources/MaliciousSiteProtection/Model/FilterDictionary.swift#L41
This memberwise initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
|
Run SwiftLint:
Sources/MaliciousSiteProtection/Model/IncrementallyUpdatableMaliciousSiteDataSet.swift#L1
Header comments should be consistent with project patterns (file_header)
|
Run SwiftLint:
Sources/MaliciousSiteProtection/MaliciousSiteDetector.swift#L110
`where` clauses are preferred over a single `if` inside a `for` (for_where)
|
Run SwiftLint:
Sources/MaliciousSiteProtection/MaliciousSiteDetector.swift#L127
Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionDataManager.swift#L25
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionDataManager.swift#L29
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionAPIClient.swift#L76
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionEmbeddedDataProvider.swift#L41
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionEmbeddedDataProvider.swift#L32
Lines should not have trailing whitespace (trailing_whitespace)
|
Run SwiftLint:
Tests/MaliciousSiteProtectionTests/Mocks/MockMaliciousSiteProtectionEmbeddedDataProvider.swift#L36
Lines should not have trailing whitespace (trailing_whitespace)
|
Run unit tests (macOS):
MaliciousSiteProtection/EmbeddedDataProvider.swift#L42
Could not load embedded data set at : Error Domain=NSCocoaErrorDomain Code=256 "The file couldn’t be opened." UserInfo={NSURL=}
|
Run unit tests (macOS)
Process completed with exit code 1.
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L59
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
Run unit tests (macOS):
Sources/Navigation/WebKitDownload.swift#L34
sendability of function types in instance method 'cancel' does not match requirement in protocol 'WebKitDownload'; this is an error in the Swift 6 language mode
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L59
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L59
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (macOS):
Sources/Navigation/Extensions/WKErrorExtension.swift#L59
extension declares a conformance of imported type 'WKError' to imported protocol 'LocalizedError'; this will not behave correctly if the owners of 'WebKit' introduce this conformance in the future
|
Run unit tests (macOS):
Sources/Navigation/DistributedNavigationDelegate.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
DerivedData/Build/Products/Debug-iphonesimulator/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/Autofill/AutofillUserScript.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/ContentBlocking/UserScripts/SurrogatesUserScript.swift#L19
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/ContentScopeScript/UserContentController.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/ContentBlocking/UserScripts/SurrogatesUserScript.swift#L19
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/ContentScopeScript/UserContentController.swift#L22
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (iOS):
Sources/BrowserServicesKit/Autofill/AutofillUserScript.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'WebKit'
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequest
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterDidStartNavigation
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterWillStartNavigation
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureBeforeWillStartNavigation
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequest
|
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestWithData
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
build-log.txt
|
34.8 KB |
|
ios-build-log.txt
|
138 KB |
|