Merge pull request #47 from samansmink/minor-fixes

minor fixes + ci tools bump
duckdb · Jul 10, 2024 · 3d1f5c8 · 3d1f5c8
2 parents 1d1a550 + 9e79034
commit 3d1f5c8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/MainDistributionPipeline.yml b/.github/workflows/MainDistributionPipeline.yml
@@ -14,7 +14,7 @@ concurrency:
 jobs:
   duckdb-stable-build:
     name: Build extension binaries
-    uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
+    uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.0.0
     with:
       extension_name: aws
       duckdb_version: v1.0.0

diff --git a/extension-ci-tools b/extension-ci-tools
diff --git a/src/aws_secret.cpp b/src/aws_secret.cpp
@@ -164,7 +164,7 @@ static unique_ptr<BaseSecret> CreateAWSSecretFromCredentialChain(ClientContext &
 		}
 	}
 
-	return result;
+	return std::move(result);
 }
 
 void CreateAwsSecretFunctions::Register(DatabaseInstance &instance) {
+239 −73		.github/workflows/_extension_distribution.yml
+11 −6		makefiles/duckdb_extension.Makefile
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     	}
-    	return result;
+    	return std::move(result);
     }
     void CreateAwsSecretFunctions::Register(DatabaseInstance &instance) {
@@ Expand Down @@