Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fruity theme #206

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Add Fruity theme #206

merged 3 commits into from
Dec 2, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Dec 1, 2021

There are several references to this theme in HTTPie docs, so supporting it should lead to less confusion for anyone using HTTPie docs with xh. In addition, I have updated all themes to not highlight the escape character with a different color.

Ticks one item from #4.

@ducaale ducaale mentioned this pull request Dec 1, 2021
28 tasks
@blyxxyz
Copy link
Collaborator

blyxxyz commented Dec 2, 2021

I have updated all themes to not highlight the escape character with a different color.

Is that just because HTTPie doesn't do it? I'm not very attached to it but I do like it.

@ducaale
Copy link
Owner Author

ducaale commented Dec 2, 2021

Is that just because HTTPie doesn't do it? I'm not very attached to it but I do like it.

I didn't have any good reasons beyond making the output similar to HTTPie. If you think the escape character highlighting could be helpful, I could revert the change.

@ducaale ducaale merged commit 95b1af2 into develop Dec 2, 2021
@ducaale ducaale deleted the fruity-theme branch December 2, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants