Improved input validation error messages for values from env variables #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In terms of the publicly-facing API, nothing changed in this PR, except for the error messages presented to end users when input validation fails for values that were provided via environment variables. Now, when an invalid value is found in an environment variable, the name of the environment variable that contained the invalid value is included in the error message. This should make it easier to troubleshoot errors caused by forgotten environment variables and other similar cases.
In the internal API, potentially breaking changes were made to some internal methods related to
ParamAction
s and their interaction withParameter
s while parsing / validating values. Unused cruft was removed, a method was refactored to move away from having a param used for a single purpose to having a separate method for that purpose, and the newenv_var
param was added so it could be included in error messages.