Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved subcommand help text, json error messages, and TimeDelta inputs #64

Merged
merged 3 commits into from
May 19, 2024

Conversation

dskrypa
Copy link
Owner

@dskrypa dskrypa commented May 19, 2024

  • Added min/max/int validation options for TimeDelta inputs, similar to NumRange inputs
  • Added a wrapper around json.load for Json inputs to provide a more user-friendly error message
  • Updated SubCommand so that if no help='...' text is provided as a class kwarg when a sub-Command is defined, but a description or docstring is present, then that description/docstring will be used as the help text when the subcommand choices are displayed in --help text. To prevent that text from being displayed when a description is provided, it is possible to specify help='' with an empty string.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (f0f331e) to head (586da29).
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   98.32%   98.34%   +0.01%     
==========================================
  Files          49       49              
  Lines        6643     6687      +44     
  Branches     1400     1407       +7     
==========================================
+ Hits         6532     6576      +44     
  Misses         95       95              
  Partials       16       16              
Flag Coverage Δ
unittests 98.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dskrypa dskrypa merged commit 857d01d into main May 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants