This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Use non swappable, non movable memory to store secrets #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klakplok
changed the title
|
This looks like a reasonable approach. I recommend using |
|
Cool! Actually, I did not introduce |
klakplok
force-pushed
the
protect-secrets
branch
from
cc40fbe to
8665264
Compare
klakplok
force-pushed
the
protect-secrets
branch
from
8665264 to
b563a24
Compare
|
@dsheets Ok, I suppose the PR is ready for a first complete review now. |
|
I have not forgotten about this PR. I've been off the grid for several weeks and I'm just now catching up. I hope to review, merge, and release this week with review tonight GMT. Thanks for your patience. |
|
ping? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsheets , this PR is a WIP, I did not proofread my code very thoroughly yet, I'd like your comments on the structure / choices before polishing it if you can find the time :).
It does not change the API (except for adding two functions and some comments), but it touches quite a lot of code in the implementation (as expected).