Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 18 exclude dirs2 #23

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Dev 18 exclude dirs2 #23

wants to merge 8 commits into from

Conversation

Arturas-K
Copy link
Contributor

@Arturas-K Arturas-K commented Jun 13, 2016

Closes #18;
Added workaround examples for #19;


This change is Reviewable

…ce, Test-TargetResource and Get-RobocopyArguments functions;

* Internal calls to Get-RobocopyArguments now use Splatting @psBoundParameters;
@Arturas-K
Copy link
Contributor Author

Hi,

Code review feedback would be appreciated.

@narrieta
Copy link
Contributor

narrieta commented Aug 4, 2016

Looks good.

I know we don't have tests for this resource, but could you add one for the new functionality?

Thanks


Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.


Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):

        }

        #this will exclude single file pattern using ExludeFiles option

Minor: typo. "Exclude". Several instances below


Comments from Reviewable

@narrieta narrieta added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Aug 4, 2016
@Arturas-K
Copy link
Contributor Author

I'm working on unit test coverage for this resource, i'll merge it into this branch when they are finished


Review status: 0 of 6 files reviewed at latest revision, all discussions resolved.


Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):

Previously, narrieta (Norberto Arrieta) wrote…

Minor: typo. "Exclude". Several instances below

Done.

Comments from Reviewable

@Arturas-K
Copy link
Contributor Author

as of last commit closes #24

@kwirkykat kwirkykat added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Aug 18, 2016
@eshaparmar
Copy link

Reviewed 3 of 5 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


DSCResource.Tests, line 1 at r2 (raw file):

Subproject commit c845d58d6b1f5f16ae2992f7b2c15e76d611281d

I don't see any unit tests and integration tests. Did i miss something?


Comments from Reviewable

@eshaparmar eshaparmar added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Sep 22, 2016
@johlju johlju added abandoned The pull request has been abandoned. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels May 17, 2018
@johlju
Copy link
Member

johlju commented May 17, 2018

Labeling this as abandoned as the original author has not been active after the last PR comment. A PR with the abandoned label can be continued by other contributor in the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants