Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xDFSNamespaceServerConfiguration resource - Fixes #16 #17

Merged
merged 10 commits into from
Jun 29, 2016
Merged

Add xDFSNamespaceServerConfiguration resource - Fixes #16 #17

merged 10 commits into from
Jun 29, 2016

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jun 5, 2016

This has been primarily added to enable FQDN mode to be turned on for DFS Namespace servers. Two other DFS Namespace server parameters were also exposed.
LdapTimeoutSec
SyncIntervalSec

Because I am using files.trimTrailingWhitespace in VS Code, some trailing white space was also trimmed from the Readme.md.

This relates to issue #15, but I will still need to determine if the other DFSN resources require changes to support FQDN mode, so I'm leaving #15 open until I've checked this.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jun 5, 2016
@PlagueHO
Copy link
Member Author

@TravisEz13 - if you get a spare moment, would you be able to review this PR for me? No rush - not a critical feature or fix.

Thanks!

@TravisEz13
Copy link
Contributor

Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):

{
    [Key, Description("Specifies the resource is a single instance, the value must be 'Yes'"), ValueMap{"Yes"}, Values{"Yes"}] String IsSingleInstance;
    [Write, Description("Specifies a time-out value, in seconds, for Lightweight Directory Access Protocol (LDAP) requests for the DFS namespace server.")] Uint32 LdapTimeoutSec;

should we spell out seconds?


Comments from Reviewable

@PlagueHO
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):

Previously, TravisEz13 (Travis Plunk) wrote…

should we spell out seconds?

@TravisEz13, I defined it as Sec to match the underlying cmdlet property, but if it you think it would be clearer as Seconds, I can change it - I'd take your advice on this one.

Comments from Reviewable

@TravisEz13
Copy link
Contributor

@HemantMahawar What do you think?

@TravisEz13
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

@TravisEz13, I defined it as Sec to match the underlying cmdlet property, but if it you think it would be clearer as Seconds, I can change it - I'd take your advice on this one.

@hemant

Comments from Reviewable

@HemantMahawar
Copy link

Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):

Previously, TravisEz13 (Travis Plunk) wrote…

@hemant

Sec is fine. We use "Sec" in PowerShell instead of seconds as a suffix to time related properties. Also built-in WaitFor\* resources follow the same pattern on its time related property (RetryIntervalSec)

Comments from Reviewable

@PlagueHO
Copy link
Member Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):

Previously, HemantMahawar (Hemant Mahawar) wrote…

Sec is fine. We use "Sec" in PowerShell instead of seconds as a suffix to time related properties. Also built-in WaitFor* resources follow the same pattern on its time related property (RetryIntervalSec)

Thanks @hemant - @TravisEz13 - it should hopefully be ready for your final review! Thanks!

Comments from Reviewable

@TravisEz13 TravisEz13 merged commit 45a3465 into dsccommunity:dev Jun 29, 2016
@TravisEz13 TravisEz13 removed the needs review The pull request needs a code review. label Jun 29, 2016
@PlagueHO PlagueHO deleted the Feature-16/xDFSNamespaceServerConfiguration branch June 29, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants