-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xDFSNamespaceServerConfiguration resource - Fixes #16 #17
Add xDFSNamespaceServerConfiguration resource - Fixes #16 #17
Conversation
…throw errors when reading/writing
@TravisEz13 - if you get a spare moment, would you be able to review this PR for me? No rush - not a critical feature or fix. Thanks! |
Reviewed 13 of 13 files at r1. DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):
should we spell out seconds? Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):
|
@HemantMahawar What do you think? |
Review status: all files reviewed at latest revision, 1 unresolved discussion. DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.schema.mof, line 5 [r1] (raw file):
|
This has been primarily added to enable FQDN mode to be turned on for DFS Namespace servers. Two other DFS Namespace server parameters were also exposed.
LdapTimeoutSec
SyncIntervalSec
Because I am using files.trimTrailingWhitespace in VS Code, some trailing white space was also trimmed from the Readme.md.
This relates to issue #15, but I will still need to determine if the other DFSN resources require changes to support FQDN mode, so I'm leaving #15 open until I've checked this.
This change is