Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertReq: Expired Certificate Validation #268

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thesmall
Copy link

@thesmall thesmall commented May 24, 2022

Pull Request (PR) description

Adds logic to exclude certificates which have already expired from being included in the array of certificates returned from the certificate store, when building a certificate request to be submitted to the PKI.

If the certificate request attempts to perform renewal on a certificate that has already expired, the certificate request will be denied by the Certification Authority with an error: Certificate not issued (Denied) Error Verifying Request Signature or Signing Certificate A required certificate is not within its validity period when verifying against the current system clock or the timestamp in the signed file..

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@PlagueHO
Copy link
Member

Hi @thesmall - are you still working on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants