Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Updating tests according to styling guide #214

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wh33ly
Copy link

@wh33ly wh33ly commented Dec 6, 2019

Pull Request (PR) description

Updating tests according to styling guide

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (c2006bb) to head (c4c1ac5).
Report is 32 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #214   +/-   ##
===================================
- Coverage    89%    87%   -2%     
===================================
  Files         7      7           
  Lines       987    987           
  Branches      0      1    +1     
===================================
- Hits        881    868   -13     
- Misses      106    118   +12     
- Partials      0      1    +1     

@PlagueHO PlagueHO self-requested a review January 24, 2020 23:35
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 24, 2020
@PlagueHO
Copy link
Member

Hi @wh33ly - I apologize for the long delay getting this reviewed. We've been moving all resources to a new CI/CD process that takes a fair amount of effort so I've been behind in my reviews.

I'm also not certain why the tests are failing as it does not look like anything you've done. I'll close/open the PR to kick the AppVeyor again.

@PlagueHO PlagueHO closed this Jan 24, 2020
@PlagueHO PlagueHO reopened this Jan 24, 2020
@PlagueHO PlagueHO changed the base branch from dev to master March 28, 2020 00:04
@wh33ly wh33ly marked this pull request as draft August 26, 2020 12:09
@PlagueHO PlagueHO changed the base branch from master to main December 31, 2020 20:27
@PlagueHO PlagueHO removed the needs review The pull request needs a code review. label Feb 19, 2021
@PlagueHO PlagueHO added the abandoned The pull request has been abandoned. label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The pull request has been abandoned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants