ADManagedServiceAccount: Add CommonName parameter

[Antiohne]

Pull Request (PR) description

Added support for setting a common name to a Managed Service Account for a longer more friendly name than the SAM account name which has a 15 character limit.

This Pull Request (PR) fixes the following issues

• Fixes ADManagedServiceAccount: Add support for setting the SAM account name and (common) name separately #644

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #661 (a1a728b) into main (715201d) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #661   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3420   +12     
===================================
+ Hits       3340   3352   +12     
  Misses       68     68           

Impacted Files	Coverage Δ
...edServiceAccount/MSFT_ADManagedServiceAccount.psm1	100% <100%> (ø)

[X-Guardian]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Antiohne)

a discussion (no related file):
This PR needs integration tests.

Have you tested this change through the full lifecycle of an ADManagedServiceAccount object and this additional property? i.e. addition, modification and deletion of an ADManagedServiceAccount with and without this property, and addition, modification and deletion of this property. This must be a non-breaking change to current usage of this resource.

---

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[Antiohne]

This PR needs integration tests.

Have you tested this change through the full lifecycle of an ADManagedServiceAccount object and this additional property? i.e. addition, modification and deletion of an ADManagedServiceAccount with and without this property, and addition, modification and deletion of this property. This must be a non-breaking change to current usage of this resource.

Yes this change is non-breaking and is based on the ADUser implementation. If you do not specify a common name the common name of the Managed User Identity will be the same as the SamAccountName. When specified the common name will be different to the SamAccountName and the Distinguished Name will be based on the specified common name.

The existing integration tests will now test that the value of the common name is the same as the SamAccountName. Additional tests are added for the creation and deletion of a managed service account with a common name. Another test will check the rename of that common name.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[Antiohne]

@X-Guardian : This change is ready for reviewing. The required integration tests are added and the full lifecycle is tested.

[Antiohne]

@X-Guardian : The requested integration tests are added in September. Is this PR now ready for review?

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[johlju]

Reviewed 3 of 4 files at r1, 2 of 3 files at r2, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @X-Guardian)

[johlju]

I push this through so we can iterate from here.