Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflicting module with macro-debugger/emit, fix dynamic-requi… #168

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

dzoep
Copy link
Collaborator

@dzoep dzoep commented Mar 29, 2024

…re of protected symbol?

Summary of Changes

[Please describe your changes]

Public Domain Dedication

  • In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)

@@ -1,20 +0,0 @@
#lang racket/base

(provide define-qi-expansion-step)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean define-qi-expansion-step is no longer used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, now the expansion steps are logged in the passes.rkt module when run-passes runs the successive passes and logs (or tries to log) the changes for macro stepper using emit-local-step. Mainly this fixes some issues when Qi code is evaluated in scribblings using sandbox evaluation.

@countvajhula
Copy link
Collaborator

Yes, for more context, this was causing some docs builds to fail. I added a workaround for this without understanding the issue (and quite honestly, without understanding the fix!) in these packages that had been reporting as failing to build docs on the package index for a few weeks:

relation
generator-util
lazytree
seq

Merging, thanks @dzoep !

@countvajhula countvajhula merged commit 798d12f into drym-org:main Mar 30, 2024
5 of 6 checks passed
@dzoep dzoep deleted the fix-emit-local-step branch March 30, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants