Unit tests for equity module #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12441522083Details
💛 - Coveralls |
apromessi
reviewed
Jan 15, 2025
| @pytest.mark.parametrize( | ||
| "prior_contribution, incoming_amount, price, expected_investment", | ||
| [ | ||
| (Decimal("0"), Decimal("0"), Decimal("100"), Decimal("0")), |
There was a problem hiding this comment.
Nit: are all of these cases actually testing different logic / use cases? Do we need them all? Might be helpful to add a comment for each one so that if one fails, we can easily identify what is supposed to happen and what logic is broken.
apromessi
reviewed
Jan 15, 2025
| (Decimal("120"), Decimal("20"), Decimal("100"), Decimal("20")), | ||
| ], | ||
| ) | ||
| @patch('oldabe.money_in.equity.ItemizedPaymentsRepo') |
There was a problem hiding this comment.
While discussing, we decided to pass Repos into functions instead of patching them in tests.
These are quite rough. It would be good to review the interfaces to see if they could be further simplified so that these tests could be leaner as well.
countvajhula
force-pushed
the
equity-unit-tests
branch
from
2964587 to
4c79ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are quite rough. It would be good to review the interfaces to see if they could be further simplified so that these tests could be leaner as well.
Public Domain Dedication
(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)