improve: LDP-2497: Add $ceApi helper and include query in server routes #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fago
requested changes
Apr 19, 2024
fago
reviewed
Apr 19, 2024
| if (config.addRequestFormat) { | ||
| useFetchOptions.query._format = 'custom_elements' | ||
| } | ||
| useFetchOptions.key = `page-${path}-${JSON.stringify(useFetchOptions.query)}` |
There was a problem hiding this comment.
if not provided, it will be generated based on the url and fetch options
--> let's better stick with the default!
There was a problem hiding this comment.
keys are different on server and client for some reason so it re-fetches and fails with internal server error in a project
There was a problem hiding this comment.
weird. let's check it in a follow-up then.
fago
requested changes
Apr 19, 2024
fago
approved these changes
Apr 21, 2024
fago
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #211