Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: LDCL-54: Add jsdocs for provided API helpers #222

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

vloss3
Copy link
Contributor

@vloss3 vloss3 commented Apr 12, 2024

No description provided.

@fago
Copy link
Contributor

fago commented Apr 12, 2024

ehm, no? why would we? when the caller wants to use
useRuntimeConfig().public.drupalCe.drupalBaseUrl
he should simply do so.

BUT - we should point that out in the documentation. this method will automatically use serverDrupalBaseUrl on the server. If the general base URL is always needed simply use return useRuntimeConfig().public.drupalCe.drupalBaseUrl

Generally, we should have documentation for all of our provided API helpers. If not, let'S add it.

@vloss3 vloss3 changed the title fix: LDCL-54: Modify getDrupalBaseUrl to always return general base url docs: LDCL-54: Add docs for provided API helpers Apr 12, 2024
@vloss3 vloss3 changed the title docs: LDCL-54: Add docs for provided API helpers docs: LDCL-54: Add jsdocs for provided API helpers Apr 12, 2024
@fago fago merged commit 0e9c3e8 into 2.x Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants