-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add-api-proxy: Add Nitro server API routes #179
Merged
Merged
Changes from 23 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
95e6897
feat: add-api-proxy: Add Nitro server API routes
vloss3 0486f4a
Remove debug code
vloss3 dc67d86
Fix tests
vloss3 0817411
Fix menu route rules and add docs
vloss3 1117aad
Add test for disabled exposeAPIRouteRules
vloss3 d3927a8
Improve docs
vloss3 1d6c9a6
Improve docs
vloss3 cca49d1
Merge remote-tracking branch 'origin/2.x' into feature/165-add-api-proxy
vloss3 72220f4
Fix module build error.
TurtlBbx 8409bce
Fix menu proxy not working.
TurtlBbx 003b311
add-api-proxy: Add README and add BC baseUrl
vloss3 bee448c
add-api-proxy: Replace routeRules with server handlers
vloss3 1bf7fc8
add-api-proxy: Remove console log
vloss3 da133ce
add-api-proxy: Handle cases where baseURL is not full URL
vloss3 f454685
add-api-proxy: Add back README commit
vloss3 82c5d53
add-api-proxy: Support i18n in menus and add README for runtime overr…
vloss3 c9feacf
add-api-proxy: Add override examples and use serverDrupalBaseUrl
vloss3 4384241
add-api-proxy: Improve README
vloss3 ad8d084
Improve README
TurtlBbx 24b5ec9
Fix a build error
TurtlBbx 03ea4cd
Fix build errors
TurtlBbx f0352c4
Fix menu endpoint proxy
TurtlBbx 51a8ac6
Improve README
TurtlBbx 401a753
Fix default options
TurtlBbx 2ea6a68
Update README.md
fago 8c098c4
correctly test BC
fago 80908d2
add-api-proxy: Update README and menu fallback
vloss3 a3940c4
Merge remote-tracking branch 'origin/2.x' into feature/165-add-api-proxy
vloss3 f5a39ae
add-api-proxy: Allow env overrides for drupalBaseUrl
vloss3 2ac578f
add-api-proxy: Update vitest
vloss3 476d1cd
add-api-proxy: Improve menu route and README
vloss3 07f0064
add-api-proxy: Small refactor
vloss3 d1ab251
add-api-proxy: Refactor menu api code
vloss3 cf1dc10
add-api-proxy: Add handler for base path
vloss3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this documents an override for the deprecated optiln. it should document it for drupalbaseUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fago @vloss3 In code, we don't support ENV override of drupalBaseUrl. It's not taken into account, as seen here.
We either:
a) Change back in README to state that we support baseUrl (and not drupalBaseUrl) override (it's used in the server proxy handler).
b) Change the code to support drupalbaseUrl override and leave the README as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed drupalBaseUrl to work with env overrides