-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Druid 0.10.1, incomplete #233
base: master
Are you sure you want to change the base?
Conversation
This PR is incomplete but I probably not going to work on it soon, so you are welcome to continue this work if you need it, please announce this with a comment to this PR if you do. |
Is this the official PR to update to druid 0.10.0 ? |
@Igosuki what do you mean by "official"? It's just a PR that I started to support Druid 0.10.1 as a dependency of Tranquility |
@leventov ok I meant it as, if I help you finish it, it's not gonna get overwritten by any core committer who already was working on it. |
@Igosuki I don't plan to continue work on this PR anytime soon so go ahead. |
@leventov Alright, thanks ! |
After updating to 0.10.1-rc2, it seems the default Guice bindings in druid force me to add a lot of modules to the Tranquility Guicer, have you come across these problems ? Do I have to implement some noops for these modules for tranquility ?
|
Yeah, the module structure changed in 0.10 so you need to pull other
modules in tranquility for it to work
…On Fri, Aug 25, 2017, 10:39 AM Gaurav M Shah ***@***.***> wrote:
tried with druid-0.10.1 but stuck with:
[info] - Default ExtensionsConfig *** FAILED ***
[info] com.google.inject.CreationException: Unable to create injector, see the following errors:
[info]
[info] 1) No implementation for java.util.Map<java.lang.Class<? extends io.druid.query.Query>, io.druid.query.QueryRunnerFactory> was bound.
[info] while locating java.util.Map<java.lang.Class<? extends io.druid.query.Query>, io.druid.query.QueryRunnerFactory>
[info] for parameter 0 at io.druid.query.DefaultQueryRunnerFactoryConglomerate.<init>(DefaultQueryRunnerFactoryConglomerate.java:36)
[info] at io.druid.guice.QueryableModule.configure(QueryableModule.java:49) (via modules: com.google.inject.util.Modules$OverrideModule -> io.druid.guice.QueryableModule)
[info]
[info] 1 error
[info] at com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:466)
[info] at com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:155)
[info] at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
[info] at com.google.inject.Guice.createInjector(Guice.java:96)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYyhhzIkwy5_O4PzMYU3fLThkjMqoGwks5sbohTgaJpZM4N8BBv>
.
|
@Igosuki Thanks. can you help me get started with test cases I would like to contribute. |
backtrace:
|
@Gauravshah the tests should be completely self-contained; this might be an issue with the tests. In particular this line seems suspicious:
Maybe it's related to a finagle version change? |
@Igosuki were you able to move forward ? |
@Gauravshah I ended up pausing that work, because 0.12 is coming out soon, and the main signature types and required modules completely changed. Plus it seems the strategy is to move away from tranquility towards kafka indexing service, will come back to that later. I am currently running the latest Tranquility with avro extensions against 0.10.x and it works fine because the index specs haven't changed. |
thanks @Igosuki , we are using kinesis so wondering how would kafka indexing service would work in that world. |
No description provided.