Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC: clarify esc_index #25

Merged
merged 2 commits into from
May 18, 2023
Merged

ESC: clarify esc_index #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6445d58
ESC: clarify esc_index
tridge May 18, 2023
ad48aaf
param: clarify that implementors may choose to make all param set per…
tridge May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion uavcan/equipment/esc/1034.Status.uavcan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ int18 rpm # Negative value indicates reverse rotation

uint7 power_rating_pct # Instant demand factor in percent (percent of maximum power); range 0% to 127%.

uint5 esc_index
uint5 esc_index # zero is first ESC. This should match the index into the cmd[] array in RawCommand
5 changes: 5 additions & 0 deletions uavcan/protocol/param/10.ExecuteOpcode.uavcan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
# with their default values. The node may require a restart in order for some changes to take effect.
#
# Other opcodes may be added in the future (for example, an opcode for switching between multiple configurations).

# note that implementors may choose to make parameter set operations
# be immediately persistent, or can choose to make them temporary,
# requiring a ExecuteOpcode with OPCODE_SAVE to put into persistent
# storage
#
uint8 OPCODE_SAVE = 0 # Save all parameters to non-volatile storage.
uint8 OPCODE_ERASE = 1 # Clear the non-volatile storage; some changes may take effect only after reboot.
Expand Down
3 changes: 3 additions & 0 deletions uavcan/protocol/param/11.GetSet.uavcan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
# discouraged to use it for anything else, because persistent ordering is not guaranteed.
#

# implementors may choose to make parameter set operations be immediately persistent, or can choose
# to make them temporary, requiring a ExecuteOpcode with OPCODE_SAVE to put into persistent storage

#
# Index of the parameter starting from 0; ignored if name is nonempty.
# Use index only to retrieve the list of parameters.
Expand Down