Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session Page #39

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Session Page #39

merged 3 commits into from
Jul 4, 2023

Conversation

kharioki
Copy link
Collaborator

@kharioki kharioki commented Jul 3, 2023

Fixes #30

Description

This PR is for the session page. While the design is clear on what should be displayed, there were certain edge cases not accounted for such as multiple speakers in one session, and also the design does not explain what happens when the share button or twitter handle is pressed. Moreso, the data structure lacks twitter_handle field so I have added some helper functions to handle this.

Fixes # (30)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kharioki kharioki requested review from antosan and brianwachira July 3, 2023 17:59
brianwachira
brianwachira approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@brianwachira brianwachira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

antosan
antosan requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue will be closed as soon as the PR gets merged, but there are some things that still need to be done on this screen. We have some TODOs in the code, but it is better to make a new issue for these remaining tasks for better visibility. @kharioki Can you open a new issue to remind us to work on what happens when we press the star icon, the share button and the twitter handles, and working on a proper "Session not found" screen to cater for broken slugs? The designs are missing these things and @brianwachira needs to get more info.

app/(app)/session/[session].tsx Outdated Show resolved Hide resolved
app/(app)/session/[session].tsx Outdated
<Image
source={{ uri: session?.session_image || '' }}
style={styles.image}
contentFit="fill"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images looks squashed because of contentFit="fill". We should give them the same treatment as we do on the home screen with cover.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted to cover with contentPosition="left" like on home screen, but because of width constraints, this may have uneven edges. if I remove contentPosition="left" the text in the image is cut. then again since the title is already in the page should that be an issue. please advice

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images have a different aspect ratio to the usage in the designs and therefore something has to give. We should keep the current options since the right side of the image only contains the graphic and no text. Cutting off the text in the image does not look good.

app/(app)/session/[session].tsx Show resolved Hide resolved
@brianwachira
Copy link
Contributor

brianwachira commented Jul 4, 2023 •
edited
Loading

This issue will be closed as soon as the PR gets merged, but there are some things that still need to be done on this screen. We have some TODOs in the code, but it is better to make a new issue for these remaining tasks for better visibility. @kharioki Can you open a new issue to remind us to work on what happens when we press the star icon, the share button and the twitter handles, and working on a proper "Session not found" screen to cater for broken slugs? The designs are missing these things and @brianwachira needs to get more info.

@antosan @kharioki True, I hadn't comprehended some of these features.

  • The star icon bookmarks a session, ( there's an endpoint for that) then on the sessions screen you can toggle the view to see only your bookmarked sessions.
  • Twitter button upon tapping it, it takes you to the speaker's Twitter profile. However, there are scenarios where a speaker didn't have a handle.
  • The "Session Not Found " one...hadn't thought of that.
  • Lemme inquire what that share button should do.

brianwachira
brianwachira requested changes Jul 4, 2023
View reviewed changes
app/(app)/session/[session].tsx Outdated Show resolved Hide resolved
app/(app)/session/[session].tsx Outdated Show resolved Hide resolved
app/(app)/session/[session].tsx Outdated Show resolved Hide resolved
@kharioki
Copy link
Collaborator Author

kharioki commented Jul 4, 2023

I've added two new issues #40 and #41. these issues will be for the session page actions and session-not-found screen

@kharioki kharioki requested review from brianwachira and antosan July 4, 2023 12:53
antosan
antosan approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brianwachira brianwachira merged commit 1e81dc5 into develop Jul 4, 2023
@brianwachira brianwachira deleted the kharioki/issue30 branch July 4, 2023 17:19
brianwachira added a commit that referenced this pull request Oct 7, 2023
@shyrynaz @kharioki
@antosan @brianwachira @mog-rn @gmwaniki
Feed list. Share with params for each feed item (#36)
3855082 
* Feed list. Share with params for each feed item

* Video Player Component (#37)

* Video Player Component
Fixes #24

* fixed video and poster contain, volume control

* custom nute/unmute button for video

* adjust lint rules (#38)

* Session Page (#39)

* Session Page
Fixes #30

* update icon color on dark mode

* added paddings, text contrasts and image fixes

* Filter Modal (#43)

* Filter Modal
Fixes #20

* added ability to select multiple filters

* modal bottom padding

* update type safety

* updated modal height constants

* Feat sessions screen (#44)

* first bad batch

* make initial commit

* make initial commit

* [feat] : add icon switch

* [feat] : make initial commit

* [feat] : change color to rgba

* [remove] : unused component

* [feat] : use new StyledSwitch component

* [enhancement] : use new StyledSwitch component

* [feat] : add more tests

* [feat] : renders different cards based on props

* [feat] : add SessionsListVertical for Sessions screen

* [feat] : cater for SessionsListCard

* [feat] : show speakers

* make initial commit

* [fix] : passing correct data type

* [enhancement] : add index to flatlist ItemSeparatorComponent props

* [enhancement] : separate renderItemSeparator

* [feat] : add helper function for time

* [enhancement] : list card component styling

* [feat] : add functions to toggle view

* [fix] : some inconsistencies

* [feat] : add getScheduleTimeAndLocation function

* [feat] : add IDateForDayButton interface

* [fix] : render item separator together with SessionCard

* [enhancement]: use new helper functions

* [enhancement] : change TouchableOpacity to TouchableWithoutFeedback

* [feat] : add handlePress function

* [feat] : show dates from schedule data

* [enhancement] : fine tune sessions

* [feat] : add bottom margin

* [enhancement] : fine tune session card content

* [fix]: order of showing labels

* [feat] : add show mysessions functionality

* [enhancement] : styledSwitch width and height

* [feat] : edit marginHorizontal

* [fix] : tests

* [fix] : revert color in theme and remove comments

* Update app/(app)/home/sessions.tsx

Suggestion by @kharioki to change iconSwitch label based on showsBookmarked state

Co-authored-by: Tony Kharioki <[email protected]>

* [feat] : add line to make validate command run

* [fix] : change avatar img border color

* [fix] : prettier styling

* [enhancement] : set dates directly

* [feat] : set isActive false so that button isn't disabled

* [feat] : add route link to speaker screen when you tap on speaker avatar

* [enhancement] : types for different variations of the card

* [fix] : remove unused function declaration

* [fix] : add screen property to SessionCard

* [fix] : handle scenarios where room is undefined

* - Remove the string type infering on getSuffixForDate helper function
- Make session card disabled when session url is empty

* [fix] : add functionality to handle scenarios theres no sessions

* [enhancement] : changing timing function to spring function and destructure switchAnimation

* [fix] : remove type assertions on room

* [fix] : how room is rendered

* [enhancement] : use expo Link instead of router

* [enhancement] : change pathname to dynamic [speaker]  file

* [enhancement] : pass speaker instead of the whole speaker object

* [fix] : add room label

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Speakers Page and <SpeakerCard /> (#45)

* Speakers Page and <SpeakerCard />
Fixes #23

* resolved centered text, abstracted function

* About Page (#46)

* About Page
Fixes #21

* [feat] : add organizingTeam mock data

* [fix] : OrganizingTeam data

* [refactor] : use content from OrganizingTeam mock data

* [enhancement] : filter organizers to individuals only

* routing to speaker page

* refactor organizer cards

* fixed device width on android

* use local asset for about page

* optimize virtualized list

* testing flashlist

* [fix] : remove placeholder

---------

Co-authored-by: brianwachira <[email protected]>

* Upgrade to Expo SDK 49 (#50)

* [chore]: setting up the SplashScreen (#48)

* [chore]: setting up the SplashScreen

* [chore]: splash.png image

* [chore]: splash.png image

* [fix]: added the .idea/ folder to .gitignore

* [chore]: splash.png image

* Delete .idea directory

* [chore]: made SplashScreen.preventAutoHideAsync() be a global scope

* [chore]: fix prettier issues in app.json

* [fix]: test not running

* [chore]: fixing issues on my branch

* [chore]: fixing issues on my branch

* Delete android directory

* Update .gitignore

* updated .gitignore

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feature/feedback page (#47)

* [enhancement]: add placeholder color and type

* [feat] disable default header, use header in page

* Feedback banner svg component

* FeedBack page initial markup and styles

* feat: inital modal setup

* [chore]: confetti asset

* add extra styles and types
- feedback input border color
- feedback header background color

* add Feedback Banner Svg

* [feat]: add feedback button component

* [feat]: Feedback Rating button test

* [feat]: add Feedback page component

* [feat]: add feedback modal.

* [fix] move submit button to component

* [fix] move back button to component

* [feat] add onSelected styling

* [fix] move pressables to  components

* [fix] use correct padding size

* [fix] use corrct text size

* [fix] use space component to add spacing

* [fix] add onSelected prop

* [chore] style cleanup and refactor

* [feat] add test for button components
- BackNavigationButton
- SubmitFeedbackButton

* [refactor] add onselected prop

* [fix] use expo image component

* [fix] change styling to camelcase

* [fix] use stack screen header component

* [feat] add modal tint

* [feat] add Banner Images

* [fix] use image background component

* [fix] improve styling and add image properties

* [chore]

* fixed feedback page imagebackground

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

---------

Co-authored-by: Tony Kharioki <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>
kharioki added a commit that referenced this pull request Oct 7, 2023
@kharioki @shyrynaz
@antosan @brianwachira @mog-rn @gmwaniki
Kharioki/issue16 (#52)
1de16c2 
* Feed list. Share with params for each feed item

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

* Sponsors and Organizers Cards
Fixes #16 and #27

* Feed list. Share with params for each feed item (#36)

* Feed list. Share with params for each feed item

* Video Player Component (#37)

* Video Player Component
Fixes #24

* fixed video and poster contain, volume control

* custom nute/unmute button for video

* adjust lint rules (#38)

* Session Page (#39)

* Session Page
Fixes #30

* update icon color on dark mode

* added paddings, text contrasts and image fixes

* Filter Modal (#43)

* Filter Modal
Fixes #20

* added ability to select multiple filters

* modal bottom padding

* update type safety

* updated modal height constants

* Feat sessions screen (#44)

* first bad batch

* make initial commit

* make initial commit

* [feat] : add icon switch

* [feat] : make initial commit

* [feat] : change color to rgba

* [remove] : unused component

* [feat] : use new StyledSwitch component

* [enhancement] : use new StyledSwitch component

* [feat] : add more tests

* [feat] : renders different cards based on props

* [feat] : add SessionsListVertical for Sessions screen

* [feat] : cater for SessionsListCard

* [feat] : show speakers

* make initial commit

* [fix] : passing correct data type

* [enhancement] : add index to flatlist ItemSeparatorComponent props

* [enhancement] : separate renderItemSeparator

* [feat] : add helper function for time

* [enhancement] : list card component styling

* [feat] : add functions to toggle view

* [fix] : some inconsistencies

* [feat] : add getScheduleTimeAndLocation function

* [feat] : add IDateForDayButton interface

* [fix] : render item separator together with SessionCard

* [enhancement]: use new helper functions

* [enhancement] : change TouchableOpacity to TouchableWithoutFeedback

* [feat] : add handlePress function

* [feat] : show dates from schedule data

* [enhancement] : fine tune sessions

* [feat] : add bottom margin

* [enhancement] : fine tune session card content

* [fix]: order of showing labels

* [feat] : add show mysessions functionality

* [enhancement] : styledSwitch width and height

* [feat] : edit marginHorizontal

* [fix] : tests

* [fix] : revert color in theme and remove comments

* Update app/(app)/home/sessions.tsx

Suggestion by @kharioki to change iconSwitch label based on showsBookmarked state

Co-authored-by: Tony Kharioki <[email protected]>

* [feat] : add line to make validate command run

* [fix] : change avatar img border color

* [fix] : prettier styling

* [enhancement] : set dates directly

* [feat] : set isActive false so that button isn't disabled

* [feat] : add route link to speaker screen when you tap on speaker avatar

* [enhancement] : types for different variations of the card

* [fix] : remove unused function declaration

* [fix] : add screen property to SessionCard

* [fix] : handle scenarios where room is undefined

* - Remove the string type infering on getSuffixForDate helper function
- Make session card disabled when session url is empty

* [fix] : add functionality to handle scenarios theres no sessions

* [enhancement] : changing timing function to spring function and destructure switchAnimation

* [fix] : remove type assertions on room

* [fix] : how room is rendered

* [enhancement] : use expo Link instead of router

* [enhancement] : change pathname to dynamic [speaker]  file

* [enhancement] : pass speaker instead of the whole speaker object

* [fix] : add room label

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Speakers Page and <SpeakerCard /> (#45)

* Speakers Page and <SpeakerCard />
Fixes #23

* resolved centered text, abstracted function

* About Page (#46)

* About Page
Fixes #21

* [feat] : add organizingTeam mock data

* [fix] : OrganizingTeam data

* [refactor] : use content from OrganizingTeam mock data

* [enhancement] : filter organizers to individuals only

* routing to speaker page

* refactor organizer cards

* fixed device width on android

* use local asset for about page

* optimize virtualized list

* testing flashlist

* [fix] : remove placeholder

---------

Co-authored-by: brianwachira <[email protected]>

* Upgrade to Expo SDK 49 (#50)

* [chore]: setting up the SplashScreen (#48)

* [chore]: setting up the SplashScreen

* [chore]: splash.png image

* [chore]: splash.png image

* [fix]: added the .idea/ folder to .gitignore

* [chore]: splash.png image

* Delete .idea directory

* [chore]: made SplashScreen.preventAutoHideAsync() be a global scope

* [chore]: fix prettier issues in app.json

* [fix]: test not running

* [chore]: fixing issues on my branch

* [chore]: fixing issues on my branch

* Delete android directory

* Update .gitignore

* updated .gitignore

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feature/feedback page (#47)

* [enhancement]: add placeholder color and type

* [feat] disable default header, use header in page

* Feedback banner svg component

* FeedBack page initial markup and styles

* feat: inital modal setup

* [chore]: confetti asset

* add extra styles and types
- feedback input border color
- feedback header background color

* add Feedback Banner Svg

* [feat]: add feedback button component

* [feat]: Feedback Rating button test

* [feat]: add Feedback page component

* [feat]: add feedback modal.

* [fix] move submit button to component

* [fix] move back button to component

* [feat] add onSelected styling

* [fix] move pressables to  components

* [fix] use correct padding size

* [fix] use corrct text size

* [fix] use space component to add spacing

* [fix] add onSelected prop

* [chore] style cleanup and refactor

* [feat] add test for button components
- BackNavigationButton
- SubmitFeedbackButton

* [refactor] add onselected prop

* [fix] use expo image component

* [fix] change styling to camelcase

* [fix] use stack screen header component

* [feat] add modal tint

* [feat] add Banner Images

* [fix] use image background component

* [fix] improve styling and add image properties

* [chore]

* fixed feedback page imagebackground

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

---------

Co-authored-by: Tony Kharioki <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>

* Sponsors and Organizers Cards

* Feed list. Share with params for each feed item

* merge fix

* packages

* Feed list. Share with params for each feed item

* bottomsheet snappoints

* Sponsors and Organizers Cards
Fixes #16 and #27

* Sponsors and Organizers Cards

* Sponsors and Organizers Cards

---------

Co-authored-by: steve <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>
kharioki added a commit that referenced this pull request Oct 29, 2023
@kharioki @brianwachira
@antosan @mog-rn @gmwaniki @shyrynaz @Patrick-web
merge develop to main (#65)
c5187c1 
* Create pull_request_template.md

* [remove] : pull request template

* [feat] : pull request template

* [fix] : types

* [feat] : type theme

* [fix] : add style props to textstyle

* [fix] : change bg to backgrounnd on ln 9 and 18

* [fix] : change ViewStyle to StyleProp<ViewStyle> on ln 10

* [fix] : remove unused lines

* [refactor] : Row component

* [fix] : add typeof iconName

* [fix] : add Icon name typeof

* [fix] : add iconName typeof

* [refactor] : type theme

* [enhancement] : add comment to react-in-jsx-scope rule

* added testing config and TODO files (#12)

* MainContainer should handle views with flatlist (#31)

* Feat add mock data (#32)

* [feat] : add mock

* [enhancement] : change them to direct export

* [feat] : add mock data and instructions

* [enhancement] : add info about writing tests

* [feat] : add types for mockdata

* Components and tests (#33)

* Not logged-in header and <GoogleSignInModal /> (#34)

* Not logged-in header and <GoogleSignInModal />
Fixes #26

* styles update

* Sessions List (#35)

* Sessions List
Fixes #14

* fixed sessions route, texts truncate

* added dynamic time and room. fixed session stack

* Video Player Component (#37)

* Video Player Component
Fixes #24

* fixed video and poster contain, volume control

* custom nute/unmute button for video

* adjust lint rules (#38)

* Session Page (#39)

* Session Page
Fixes #30

* update icon color on dark mode

* added paddings, text contrasts and image fixes

* Filter Modal (#43)

* Filter Modal
Fixes #20

* added ability to select multiple filters

* modal bottom padding

* update type safety

* updated modal height constants

* Feat sessions screen (#44)

* first bad batch

* make initial commit

* make initial commit

* [feat] : add icon switch

* [feat] : make initial commit

* [feat] : change color to rgba

* [remove] : unused component

* [feat] : use new StyledSwitch component

* [enhancement] : use new StyledSwitch component

* [feat] : add more tests

* [feat] : renders different cards based on props

* [feat] : add SessionsListVertical for Sessions screen

* [feat] : cater for SessionsListCard

* [feat] : show speakers

* make initial commit

* [fix] : passing correct data type

* [enhancement] : add index to flatlist ItemSeparatorComponent props

* [enhancement] : separate renderItemSeparator

* [feat] : add helper function for time

* [enhancement] : list card component styling

* [feat] : add functions to toggle view

* [fix] : some inconsistencies

* [feat] : add getScheduleTimeAndLocation function

* [feat] : add IDateForDayButton interface

* [fix] : render item separator together with SessionCard

* [enhancement]: use new helper functions

* [enhancement] : change TouchableOpacity to TouchableWithoutFeedback

* [feat] : add handlePress function

* [feat] : show dates from schedule data

* [enhancement] : fine tune sessions

* [feat] : add bottom margin

* [enhancement] : fine tune session card content

* [fix]: order of showing labels

* [feat] : add show mysessions functionality

* [enhancement] : styledSwitch width and height

* [feat] : edit marginHorizontal

* [fix] : tests

* [fix] : revert color in theme and remove comments

* Update app/(app)/home/sessions.tsx

Suggestion by @kharioki to change iconSwitch label based on showsBookmarked state

Co-authored-by: Tony Kharioki <[email protected]>

* [feat] : add line to make validate command run

* [fix] : change avatar img border color

* [fix] : prettier styling

* [enhancement] : set dates directly

* [feat] : set isActive false so that button isn't disabled

* [feat] : add route link to speaker screen when you tap on speaker avatar

* [enhancement] : types for different variations of the card

* [fix] : remove unused function declaration

* [fix] : add screen property to SessionCard

* [fix] : handle scenarios where room is undefined

* - Remove the string type infering on getSuffixForDate helper function
- Make session card disabled when session url is empty

* [fix] : add functionality to handle scenarios theres no sessions

* [enhancement] : changing timing function to spring function and destructure switchAnimation

* [fix] : remove type assertions on room

* [fix] : how room is rendered

* [enhancement] : use expo Link instead of router

* [enhancement] : change pathname to dynamic [speaker]  file

* [enhancement] : pass speaker instead of the whole speaker object

* [fix] : add room label

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Speakers Page and <SpeakerCard /> (#45)

* Speakers Page and <SpeakerCard />
Fixes #23

* resolved centered text, abstracted function

* About Page (#46)

* About Page
Fixes #21

* [feat] : add organizingTeam mock data

* [fix] : OrganizingTeam data

* [refactor] : use content from OrganizingTeam mock data

* [enhancement] : filter organizers to individuals only

* routing to speaker page

* refactor organizer cards

* fixed device width on android

* use local asset for about page

* optimize virtualized list

* testing flashlist

* [fix] : remove placeholder

---------

Co-authored-by: brianwachira <[email protected]>

* Upgrade to Expo SDK 49 (#50)

* [chore]: setting up the SplashScreen (#48)

* [chore]: setting up the SplashScreen

* [chore]: splash.png image

* [chore]: splash.png image

* [fix]: added the .idea/ folder to .gitignore

* [chore]: splash.png image

* Delete .idea directory

* [chore]: made SplashScreen.preventAutoHideAsync() be a global scope

* [chore]: fix prettier issues in app.json

* [fix]: test not running

* [chore]: fixing issues on my branch

* [chore]: fixing issues on my branch

* Delete android directory

* Update .gitignore

* updated .gitignore

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feature/feedback page (#47)

* [enhancement]: add placeholder color and type

* [feat] disable default header, use header in page

* Feedback banner svg component

* FeedBack page initial markup and styles

* feat: inital modal setup

* [chore]: confetti asset

* add extra styles and types
- feedback input border color
- feedback header background color

* add Feedback Banner Svg

* [feat]: add feedback button component

* [feat]: Feedback Rating button test

* [feat]: add Feedback page component

* [feat]: add feedback modal.

* [fix] move submit button to component

* [fix] move back button to component

* [feat] add onSelected styling

* [fix] move pressables to  components

* [fix] use correct padding size

* [fix] use corrct text size

* [fix] use space component to add spacing

* [fix] add onSelected prop

* [chore] style cleanup and refactor

* [feat] add test for button components
- BackNavigationButton
- SubmitFeedbackButton

* [refactor] add onselected prop

* [fix] use expo image component

* [fix] change styling to camelcase

* [fix] use stack screen header component

* [feat] add modal tint

* [feat] add Banner Images

* [fix] use image background component

* [fix] improve styling and add image properties

* [chore]

* fixed feedback page imagebackground

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feed list. Share with params for each feed item (#36)

* Feed list. Share with params for each feed item

* Video Player Component (#37)

* Video Player Component
Fixes #24

* fixed video and poster contain, volume control

* custom nute/unmute button for video

* adjust lint rules (#38)

* Session Page (#39)

* Session Page
Fixes #30

* update icon color on dark mode

* added paddings, text contrasts and image fixes

* Filter Modal (#43)

* Filter Modal
Fixes #20

* added ability to select multiple filters

* modal bottom padding

* update type safety

* updated modal height constants

* Feat sessions screen (#44)

* first bad batch

* make initial commit

* make initial commit

* [feat] : add icon switch

* [feat] : make initial commit

* [feat] : change color to rgba

* [remove] : unused component

* [feat] : use new StyledSwitch component

* [enhancement] : use new StyledSwitch component

* [feat] : add more tests

* [feat] : renders different cards based on props

* [feat] : add SessionsListVertical for Sessions screen

* [feat] : cater for SessionsListCard

* [feat] : show speakers

* make initial commit

* [fix] : passing correct data type

* [enhancement] : add index to flatlist ItemSeparatorComponent props

* [enhancement] : separate renderItemSeparator

* [feat] : add helper function for time

* [enhancement] : list card component styling

* [feat] : add functions to toggle view

* [fix] : some inconsistencies

* [feat] : add getScheduleTimeAndLocation function

* [feat] : add IDateForDayButton interface

* [fix] : render item separator together with SessionCard

* [enhancement]: use new helper functions

* [enhancement] : change TouchableOpacity to TouchableWithoutFeedback

* [feat] : add handlePress function

* [feat] : show dates from schedule data

* [enhancement] : fine tune sessions

* [feat] : add bottom margin

* [enhancement] : fine tune session card content

* [fix]: order of showing labels

* [feat] : add show mysessions functionality

* [enhancement] : styledSwitch width and height

* [feat] : edit marginHorizontal

* [fix] : tests

* [fix] : revert color in theme and remove comments

* Update app/(app)/home/sessions.tsx

Suggestion by @kharioki to change iconSwitch label based on showsBookmarked state

Co-authored-by: Tony Kharioki <[email protected]>

* [feat] : add line to make validate command run

* [fix] : change avatar img border color

* [fix] : prettier styling

* [enhancement] : set dates directly

* [feat] : set isActive false so that button isn't disabled

* [feat] : add route link to speaker screen when you tap on speaker avatar

* [enhancement] : types for different variations of the card

* [fix] : remove unused function declaration

* [fix] : add screen property to SessionCard

* [fix] : handle scenarios where room is undefined

* - Remove the string type infering on getSuffixForDate helper function
- Make session card disabled when session url is empty

* [fix] : add functionality to handle scenarios theres no sessions

* [enhancement] : changing timing function to spring function and destructure switchAnimation

* [fix] : remove type assertions on room

* [fix] : how room is rendered

* [enhancement] : use expo Link instead of router

* [enhancement] : change pathname to dynamic [speaker]  file

* [enhancement] : pass speaker instead of the whole speaker object

* [fix] : add room label

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Speakers Page and <SpeakerCard /> (#45)

* Speakers Page and <SpeakerCard />
Fixes #23

* resolved centered text, abstracted function

* About Page (#46)

* About Page
Fixes #21

* [feat] : add organizingTeam mock data

* [fix] : OrganizingTeam data

* [refactor] : use content from OrganizingTeam mock data

* [enhancement] : filter organizers to individuals only

* routing to speaker page

* refactor organizer cards

* fixed device width on android

* use local asset for about page

* optimize virtualized list

* testing flashlist

* [fix] : remove placeholder

---------

Co-authored-by: brianwachira <[email protected]>

* Upgrade to Expo SDK 49 (#50)

* [chore]: setting up the SplashScreen (#48)

* [chore]: setting up the SplashScreen

* [chore]: splash.png image

* [chore]: splash.png image

* [fix]: added the .idea/ folder to .gitignore

* [chore]: splash.png image

* Delete .idea directory

* [chore]: made SplashScreen.preventAutoHideAsync() be a global scope

* [chore]: fix prettier issues in app.json

* [fix]: test not running

* [chore]: fixing issues on my branch

* [chore]: fixing issues on my branch

* Delete android directory

* Update .gitignore

* updated .gitignore

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feature/feedback page (#47)

* [enhancement]: add placeholder color and type

* [feat] disable default header, use header in page

* Feedback banner svg component

* FeedBack page initial markup and styles

* feat: inital modal setup

* [chore]: confetti asset

* add extra styles and types
- feedback input border color
- feedback header background color

* add Feedback Banner Svg

* [feat]: add feedback button component

* [feat]: Feedback Rating button test

* [feat]: add Feedback page component

* [feat]: add feedback modal.

* [fix] move submit button to component

* [fix] move back button to component

* [feat] add onSelected styling

* [fix] move pressables to  components

* [fix] use correct padding size

* [fix] use corrct text size

* [fix] use space component to add spacing

* [fix] add onSelected prop

* [chore] style cleanup and refactor

* [feat] add test for button components
- BackNavigationButton
- SubmitFeedbackButton

* [refactor] add onselected prop

* [fix] use expo image component

* [fix] change styling to camelcase

* [fix] use stack screen header component

* [feat] add modal tint

* [feat] add Banner Images

* [fix] use image background component

* [fix] improve styling and add image properties

* [chore]

* fixed feedback page imagebackground

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

---------

Co-authored-by: Tony Kharioki <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>

* Kharioki/issue16 (#52)

* Feed list. Share with params for each feed item

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

* Sponsors and Organizers Cards
Fixes #16 and #27

* Feed list. Share with params for each feed item (#36)

* Feed list. Share with params for each feed item

* Video Player Component (#37)

* Video Player Component
Fixes #24

* fixed video and poster contain, volume control

* custom nute/unmute button for video

* adjust lint rules (#38)

* Session Page (#39)

* Session Page
Fixes #30

* update icon color on dark mode

* added paddings, text contrasts and image fixes

* Filter Modal (#43)

* Filter Modal
Fixes #20

* added ability to select multiple filters

* modal bottom padding

* update type safety

* updated modal height constants

* Feat sessions screen (#44)

* first bad batch

* make initial commit

* make initial commit

* [feat] : add icon switch

* [feat] : make initial commit

* [feat] : change color to rgba

* [remove] : unused component

* [feat] : use new StyledSwitch component

* [enhancement] : use new StyledSwitch component

* [feat] : add more tests

* [feat] : renders different cards based on props

* [feat] : add SessionsListVertical for Sessions screen

* [feat] : cater for SessionsListCard

* [feat] : show speakers

* make initial commit

* [fix] : passing correct data type

* [enhancement] : add index to flatlist ItemSeparatorComponent props

* [enhancement] : separate renderItemSeparator

* [feat] : add helper function for time

* [enhancement] : list card component styling

* [feat] : add functions to toggle view

* [fix] : some inconsistencies

* [feat] : add getScheduleTimeAndLocation function

* [feat] : add IDateForDayButton interface

* [fix] : render item separator together with SessionCard

* [enhancement]: use new helper functions

* [enhancement] : change TouchableOpacity to TouchableWithoutFeedback

* [feat] : add handlePress function

* [feat] : show dates from schedule data

* [enhancement] : fine tune sessions

* [feat] : add bottom margin

* [enhancement] : fine tune session card content

* [fix]: order of showing labels

* [feat] : add show mysessions functionality

* [enhancement] : styledSwitch width and height

* [feat] : edit marginHorizontal

* [fix] : tests

* [fix] : revert color in theme and remove comments

* Update app/(app)/home/sessions.tsx

Suggestion by @kharioki to change iconSwitch label based on showsBookmarked state

Co-authored-by: Tony Kharioki <[email protected]>

* [feat] : add line to make validate command run

* [fix] : change avatar img border color

* [fix] : prettier styling

* [enhancement] : set dates directly

* [feat] : set isActive false so that button isn't disabled

* [feat] : add route link to speaker screen when you tap on speaker avatar

* [enhancement] : types for different variations of the card

* [fix] : remove unused function declaration

* [fix] : add screen property to SessionCard

* [fix] : handle scenarios where room is undefined

* - Remove the string type infering on getSuffixForDate helper function
- Make session card disabled when session url is empty

* [fix] : add functionality to handle scenarios theres no sessions

* [enhancement] : changing timing function to spring function and destructure switchAnimation

* [fix] : remove type assertions on room

* [fix] : how room is rendered

* [enhancement] : use expo Link instead of router

* [enhancement] : change pathname to dynamic [speaker]  file

* [enhancement] : pass speaker instead of the whole speaker object

* [fix] : add room label

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Speakers Page and <SpeakerCard /> (#45)

* Speakers Page and <SpeakerCard />
Fixes #23

* resolved centered text, abstracted function

* About Page (#46)

* About Page
Fixes #21

* [feat] : add organizingTeam mock data

* [fix] : OrganizingTeam data

* [refactor] : use content from OrganizingTeam mock data

* [enhancement] : filter organizers to individuals only

* routing to speaker page

* refactor organizer cards

* fixed device width on android

* use local asset for about page

* optimize virtualized list

* testing flashlist

* [fix] : remove placeholder

---------

Co-authored-by: brianwachira <[email protected]>

* Upgrade to Expo SDK 49 (#50)

* [chore]: setting up the SplashScreen (#48)

* [chore]: setting up the SplashScreen

* [chore]: splash.png image

* [chore]: splash.png image

* [fix]: added the .idea/ folder to .gitignore

* [chore]: splash.png image

* Delete .idea directory

* [chore]: made SplashScreen.preventAutoHideAsync() be a global scope

* [chore]: fix prettier issues in app.json

* [fix]: test not running

* [chore]: fixing issues on my branch

* [chore]: fixing issues on my branch

* Delete android directory

* Update .gitignore

* updated .gitignore

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feature/feedback page (#47)

* [enhancement]: add placeholder color and type

* [feat] disable default header, use header in page

* Feedback banner svg component

* FeedBack page initial markup and styles

* feat: inital modal setup

* [chore]: confetti asset

* add extra styles and types
- feedback input border color
- feedback header background color

* add Feedback Banner Svg

* [feat]: add feedback button component

* [feat]: Feedback Rating button test

* [feat]: add Feedback page component

* [feat]: add feedback modal.

* [fix] move submit button to component

* [fix] move back button to component

* [feat] add onSelected styling

* [fix] move pressables to  components

* [fix] use correct padding size

* [fix] use corrct text size

* [fix] use space component to add spacing

* [fix] add onSelected prop

* [chore] style cleanup and refactor

* [feat] add test for button components
- BackNavigationButton
- SubmitFeedbackButton

* [refactor] add onselected prop

* [fix] use expo image component

* [fix] change styling to camelcase

* [fix] use stack screen header component

* [feat] add modal tint

* [feat] add Banner Images

* [fix] use image background component

* [fix] improve styling and add image properties

* [chore]

* fixed feedback page imagebackground

---------

Co-authored-by: Tony Kharioki <[email protected]>

* Feed list. Share with params for each feed item

* merge fix

* feedlist fixes

* packages

* bottomsheet snappoints

* type fix

* order recent first

* resolved fixes

---------

Co-authored-by: Tony Kharioki <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>

* Sponsors and Organizers Cards

* Feed list. Share with params for each feed item

* merge fix

* packages

* Feed list. Share with params for each feed item

* bottomsheet snappoints

* Sponsors and Organizers Cards
Fixes #16 and #27

* Sponsors and Organizers Cards

* Sponsors and Organizers Cards

---------

Co-authored-by: steve <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>

* fix redirect warning (#56)

* Removed auth flow from header bar (#58)

* Removed auth flow headers

* removed the signout functionality and marked todos

* removed handlePress from <HeaderRight />

* removed avatar

---------

Co-authored-by: Tony Kharioki <[email protected]>

* [refactor] : change router.replace() to router.push() (#60)

* Feat session page actions (#62)

* update react-native version

* [fix] : change route.replace to route.push

* [feat] : add share functionality

* remove user auth

* add linking and redirect to twitter functionality

* API integration and Setup Tanstack Query (#63)

* API integration and Setup Tanstack Query
Fixes #61

* typedefs

* test utils

* env vars and updated contributing guidelines

* Speaker Page (#64)

* Speaker Page
Fixes #22

* [feat] : change title based on person type ( organizer or speaker )

* update react native version

* [feat] : add border color on img

* [feat] : add correct border color

* [chore] : fine tune

* speaker details from api, fixed styling

* new event slug, handle empty feed, twitter update

* speaker page scrollview

* empty feed in dark mode

* changed [speaker] page to [profile]

* hide sponsors card

---------

Co-authored-by: brianwachira <[email protected]>

---------

Co-authored-by: brianwachira <[email protected]>
Co-authored-by: Antony Sande <[email protected]>
Co-authored-by: Amos Nyaburi <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: stephen muchiri <[email protected]>
Co-authored-by: Just Patrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianwachira brianwachira brianwachira approved these changes

@antosan antosan antosan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session Page
3 participants
@kharioki @brianwachira @antosan