[PG]: Fix set transaction empty config error in pg-core #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an empty config object is supplied for postgres transactions, the client issues the query `set transaction ;` which causes a postgres parsing error for the pglite and postgres-js drivers. This commit uses the same approach seen in drizzle-orms mysql driver to only execute the `set transaction` sql when a non-empty config object is supplied to the transaction.
Remedy indentation formatting to match codebase conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty config object is supplied for postgres transactions, the client issues the query
'set transaction ;'which causes a postgres parsing error for the pglite and postgres-js drivers. This commit uses the same approach seen in drizzle-orm's mysql-core here and here to only execute theset transactionsql when a non-empty config object is supplied to the transaction.Addresses bug identified in this issue.