Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert result to str before regex #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alindman
Copy link

Also more logging if there are no matches.

update and add/remove sections as needed

New Features

please describe new capabilities

Fixes

please list/describe an fixes, including links to related issues

Testing

please describe both unit tests included and any integration tests conducted

Prior to merging for releases:

  • update the project's version in the top-level CMakeLists.txt file
  • update the appVersion to be the new container image tag version in chart/Chart.yaml

Also more logging if there are no matches.
@wcpettus
Copy link
Contributor

from a consistency perspective, dripline has traditionally sent unicode in packets on the mesh - the bytes encoding from the ethernet socket.recv is a bit of an anomaly
should consider the most uniform implementation

@wcpettus
Copy link
Contributor

wcpettus commented Jun 3, 2024

That this isn't the case indicates that the code is doing something unexpected somewhere in one of the passes. I would recommend tracking the type of this reply through this chain - particularly right before it leaves the ethernet_scpi_service in send_to_device and right after on_get of FormatEntity gets it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants