Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the result of GpsLocation is consistant when running the regression tests #419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefanlenselink
Copy link

While preparing a different pull request and running the regression tests tests in metadata-extractor-images for both mov and mp4 files differ in the GpsLocation.

The cause is the Metadata tag is starting with a copyright symbol; while the source-code did not have any / use to have it but it's not there anymore.

Proposed solution is to strip-off the Copyright (and for completeness the @ symbol) and possibly any localisation and compare to the base tag name.

Inspriration / comments taken from: https://exiftool.org/TagNames/QuickTime.html

…ssion tests in metadata-extractor-images for both mov and mp4 files.
@drewnoakes
Copy link
Owner

Thanks, this looks good. I'll need to pull it down and run across the regression suite to see what's what.

Also I've been slowly working to improve IsoBmff parsing, which would help with this here. We'd be comparing the original byte arrays, rather than strings (which can hit problems with encoding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants