Support NativeAOT #397
Merged
Support NativeAOT #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
force-pushed
the
native-aot
branch
2 times, most recently
from
d9dedbb
to
cecec61
Compare
This enables support for NativeAOT (Ahead-of-time native compilation during publish). Doing so required adding a `net8.0` target, which also highlighted a few nullable annotations that needed updating.
drewnoakes
force-pushed
the
native-aot
branch
from
cecec61
to
6064964
Compare
Numpsy
reviewed
Feb 5, 2024
| @@ -221,7 +221,11 @@ public static bool CanContainMetadata(this JpegSegmentType type) | |||
| } | |||
|
|
|||
| /// <summary>Gets JPEG segment types that might contain metadata.</summary> | |||
| #if NET5_0_OR_GREATER | |||
| public static IReadOnlyList<JpegSegmentType> CanContainMetadataTypes { get; } = Enum.GetValues<JpegSegmentType>().Cast<JpegSegmentType>().Where(type => type.CanContainMetadata()).ToList(); | |||
There was a problem hiding this comment.
Is the Cast<JpegSegmentType>() needed on this path? (I think the GetValues() returns a JpegSegmentType[] already ?)
There was a problem hiding this comment.
Good call. I'll fix it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
This enables support for NativeAOT (Ahead-of-time native compilation during publish). Doing so required adding a
net8.0target, which also highlighted a few nullable annotations that needed updating.We also add a publish step to CI, so that any future change that would break NativeAOT is caught before merge.