GeoTIFF fixes + add test #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don-vip
force-pushed
the
geotiff-fixes-and-test
branch
from
90aab46
to
f3deda5
Compare
|
This looks great with one caveat: we don't add test images to this repo. Instead, we add them to https://github.com/drewnoakes/metadata-extractor-images, where the regression tests track changes over time from each of the Java and .NET implementations, along with a diff of the outputs from each. Ideally they should produce the same values. Adding images to this repo (or the Java repo) increase the size significantly. |
drewnoakes
pushed a commit
that referenced
this pull request
Jan 22, 2024
Merged
|
I moved the code changes here to #374. Thanks again! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported bug fixes and tests from drewnoakes/metadata-extractor#586
I got a behaviour difference between Java and .NET regarding the description of TagGeoTiffGeoKeys, I had to comment this check to get the test to pass, I don't understand why:
//Assert.Equal("[32 values]", exif.GetDescription(ExifDirectoryBase.TagGeoTiffGeoKeys));