Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#74] Replaced custom git commands. #78

Merged
merged 24 commits into from
Mar 19, 2024

Conversation

tannguyen04
Copy link
Contributor

@tannguyen04 tannguyen04 commented Mar 15, 2024

Checklist before requesting a review

closes #64

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

@tannguyen04 tannguyen04 changed the title [#74] updated git custom command. [#74] Replaced custom git commands. Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 41.71779% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 22.87%. Comparing base (a0e5cc4) to head (bbef9c5).

Files Patch % Lines
src/Artifact.php 0.00% 91 Missing ⚠️
src/Commands/ArtifactCommand.php 0.00% 2 Missing ⚠️
src/FilesystemTrait.php 0.00% 1 Missing ⚠️
src/GitArtifactGitRepository.php 98.52% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #78       +/-   ##
==========================================
+ Coverage   6.50%   22.87%   +16.36%     
==========================================
  Files          5        7        +2     
  Lines        461      529       +68     
==========================================
+ Hits          30      121       +91     
+ Misses       431      408       -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.idea/workspace.xml Outdated Show resolved Hide resolved
@tannguyen04 tannguyen04 marked this pull request as ready for review March 18, 2024 02:06
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
Please see my inline comments.

src/Artifact.php Outdated Show resolved Hide resolved
src/GitArtifactGitRepository.php Outdated Show resolved Hide resolved
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
This is so much cleaner! Great stuff.

@AlexSkrypnyk AlexSkrypnyk merged commit 8f8307c into main Mar 19, 2024
9 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/replace-custom-git-command branch March 19, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom Git command with a 3rd party package
3 participants