Fix config/mode for ubisys devices S1/S2(-R)/J1(-R)
#7493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@Zehir looks like the validator needs a small addition, the |
SwoopX
changed the title
config/mode für ubisys devices S1/S2(-R)/J1(-R)config/mode for ubisys devices S1/S2(-R)/J1(-R)
|
@manup I have updated the validator, you can re run the checks |
Cool thanks, all green now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, apparently, the code is stepping on its own foot here. For a DDF to be able to really use config/mode, a special meta item needs to be set, which is missing for all ubisys devices offering a ZHASwitch resource. However, the legacy code for setting the mode is still available, but is never reached due to code precedence.
The PR satisfies now all requirements for the DDF code and works with the respective configuration values. Additionally, the respective legacy code is removed, as it wasn't used anyway anymore.