Got unit tests passing again + other cleanup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…U and PD commands." This reverts commit b86000b. Revert "No, really, this time it's fixed." This reverts commit a90a8ce. Revert "Whoops, the bug in pens_updown_to_papr.py wasn't quite fixed. Now it is." This reverts commit 71bdf46. Revert "fixed bug in pens_updown_to_papr.py that was overwriting contents of list passed to function." This reverts commit 35151f9.
- Updated INSTALL - Added tox for testing against python 2.7
- Added note on compiling hp2xx in Mac OSX - Fixed tutorial example - Added exception handling to serial device connection
Fix broken tests, and other improvements
willprice
added a commit
to willprice/chiplotle
that referenced
this pull request
Aug 20, 2018
See https://github.com/drepetto/chiplotle/blob/13ac28a7645a018a4bc62980cb174627ca6b5b54/chiplotle/tools/hpgltools/pens_updown_to_papr.py I lifted the code directly from there as the test looked to have been originally broken, there is an open pull request to fix this issue on the mainline at drepetto#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toxto run unit tests against Python 2.7