Configured the EventGrid Reaction to use different schemas #138
+108
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruokun-niu
requested review from
amansinghoriginal,
danielgerlag and
agentofreality
danielgerlag
reviewed
Jan 7, 2025
Comment on lines
69
to
71
| eventGridSchema: | ||
| type: string | ||
| default: CloudEvents |
There was a problem hiding this comment.
Suggested change
| eventGridSchema: | |
| type: string | |
| default: CloudEvents | |
| eventGridSchema: | |
| type: string | |
| enum: | |
| - "CloudEvents" | |
| - "EventGrid" | |
| default: "CloudEvents" |
This will also enable validation of one of these 2 options.
There was a problem hiding this comment.
Also, it looks like we are missing the format (packed/unpacked) config value?
There was a problem hiding this comment.
I think maybe in the future we should make this format property a default value in the reaction_provider, so that we dont have to implement this for every reaction
| { | ||
| _logger.LogError($"Error sending message to Event Grid: {resp.Content.ToString()}"); | ||
| throw new Exception($"Error sending message to Event Grid: {resp.Content.ToString()}"); | ||
| if (_eventGridSchema == "cloudevents") { |
There was a problem hiding this comment.
We could store an enum in _eventGridSchema to avoid doing a string comparison for every event.
agentofreality
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the EventGrid reaction only supports eventgrid topics that use
CloudEventsas the schema.This PR configures the Reaction by adding a new property called
eventGridSchema. The default value of this property is set toCloudEvents, which publishes CloudEvents to the EventGrid topic. This property can be set toEventGridto publish events in the EventGrid schema to the topic.Type of change
Fixes: #issue_number