README and testcases update for MaxLen and Approx options #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is really a weird day... 🤯 This library usually sees contributions only once a year, but now we've got two on a single day. Only to be fair, #11 was opened earlier, so I accepted it first. However, I appreciate that you added a test and edited the readme. If you don't mind, can you please leave out our your changes form stream.go, so I can merge the test and readme edit? Thanks for your contribution! 🙂 |
saisrikark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to limit the number of messages stored in a stream.
This ensures that streams consume a fixed amount of storage and prevents piling up of messages.
There is already a TTL option.
But, in load scenarios the messages might still pile up within the TTL.